Bug 7686

Summary:	Tax rate wrong calculation in reception summary page
Product:	Koha	Reporter:	Koha Team University Lyon 3 <koha>
Component:	Acquisitions	Assignee:	Koha Team University Lyon 3 <koha>
Status:	RESOLVED DUPLICATE	QA Contact:	Ian Walls <koha.sekjal>
Severity:	normal
Priority:	P3	CC:	adrien.saurat, chrish, jean-manuel.broust, jonathan.druart, koha, mathsabypro
Version:	3.8
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Bug Depends on:	5335
Bug Blocks:
Attachments:	Tax rate wrong calculation in reception summary page Already received table example Wrong tax calculation in reception summary page signed off patch

Description Koha Team University Lyon 3 2012-03-08 17:48:00 UTC Comment hidden (obsolete)

Created attachment 8098 [details] [review]
Tax rate wrong calculation in reception summary page

In the Already received table (bottom of the page) :
Tax rate is purely added to Total without beeing multiplied by it
example for a 5,5% tax rate (0,055) on a 455 Total :
The Total displays  455,06 (455 + 0,055 round to 0,06) instead of
455 + (455 x 0,055)= 480,02.

Comment 1 Koha Team University Lyon 3 2012-03-08 17:49:24 UTC

Created attachment 8099 [details]
Already received table example

Comment 2 jmbroust 2012-03-20 10:20:49 UTC

There is a problem if the vendor's prices are tax included (List Item Price Includes Tax: Yes and Invoice Item Price Includes Tax: Yes) the tva is added one more time when receiving, so as prices after receiving are wrong.

Comment 3 Koha Team University Lyon 3 2012-05-31 15:56:20 UTC Comment hidden (obsolete)

Created attachment 9864 [details] [review]
Wrong tax calculation in reception summary page

This new patch takes into account the included/not included tax parameter

Comment 4 Katrin Fischer 2012-05-31 16:09:36 UTC

Hi Team Lyon 3,
glad to see your work on that! Perhaps bug 2865 is realted to this bug?

Comment 5 Adrien SAURAT 2012-06-10 15:43:34 UTC

Created attachment 10132 [details] [review]
signed off patch

Tested OK with :
1/ tax calculated at reception
2/ tax included at order

Comment 6 Jonathan Druart 2012-06-14 13:41:54 UTC

Please verify that this issue is not fixed by patch for Bug 5335 before continuing the workflow of this bug. Bug 5335 has already been rebased a lot of time and it is very difficult to do it.

Comment 7 Ian Walls 2012-06-15 17:33:36 UTC

Setting status to "In Discussion" while 5335 is checked.

Comment 8 Katrin Fischer 2012-10-27 12:31:54 UTC

Bug 5335 has been pushed to master - is this patch obsolete now?

Comment 9 Chris Hall 2013-03-13 23:08:02 UTC

I think this patch still needs to be applied to 3.8.x.

I tested on 3.8.x using a vendor where prices were gst exclusive, the gst calculation on the acquistions receipt page was still incorrect.

For a price of '11' and a gist setting of '0.125' current 3.8.x will show this as a total or '11.125' rather than the expected '12.375' (or 12.38 once rounded).

Applying this patch fixes this bug, the total price now shows correctly as '12.38'.

Comment 10 Koha Team University Lyon 3 2014-04-10 08:21:14 UTC


*** This bug has been marked as a duplicate of bug 10461 ***