Summary: | Change state of controls based on whether boxes are checked | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jcamins, paul.poulain, wizzyrea |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | |||
Bug Blocks: | 6264 | ||
Attachments: |
Bug 7719 - Change state of controls based on whether boxes are checked
Bug 7719 - Change state of controls based on whether boxes are checked |
Description
Owen Leonard
2012-03-14 18:34:13 UTC
Created attachment 8207 [details] [review] Bug 7719 - Change state of controls based on whether boxes are checked Some OPAC interface controls cannot function unless a checkbox is checked. Examples: - Placing a hold on multiple items in the cart window or on a list view page - Adding tags to multiple items in the cart window or on a list view page - Removing one or more items from the cart window - Removing one or more items from a list on the list view page - Adding one or more items to a list from the cart window This patch moves these controls into a separate div in which links are enabled or disabled based on whether checkboxes are checked. It does so on two pages: The lists view page (when viewing the contents of a list) and in the cart window. Links which are in their disabled state should not perform any action. After checking one or more checkboxes the links should become active and behave normally. Created attachment 8208 [details] [review] Bug 7719 - Change state of controls based on whether boxes are checked Some OPAC interface controls cannot function unless a checkbox is checked. Examples: - Placing a hold on multiple items in the cart window or on a list view page - Adding tags to multiple items in the cart window or on a list view page - Removing one or more items from the cart window - Removing one or more items from a list on the list view page - Adding one or more items to a list from the cart window This patch moves these controls into a separate div in which links are enabled or disabled based on whether checkboxes are checked. It does so on two pages: The lists view page (when viewing the contents of a list) and in the cart window. Links which are in their disabled state should not perform any action. After checking one or more checkboxes the links should become active and behave normally. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Works in chrome and firefox (latest). Passes tests. I have one qualm about this- will it degrade gracefully for browsers without javascript enabled? > I have one qualm about this- will it degrade gracefully for browsers without
> javascript enabled?
Because the controls perform functions which are only available if JavaScript is enabled this patch causes no additional loss of functionality to users with JS turned off. As with current master, the controls do not appear if JS is turned off.
I do see a problem where one of my labels still shows up with JS turned off. I'll submit a follow-up.
Template only change, easy to read, fails equally gracefully with JS turned off. Marking Passed QA patch pushed, a nice enhancement that 3.6 users will also enjoy ! |