Description
Julian Maurice
2012-03-19 14:42:42 UTC
Created attachment 8281 [details] [review] Update opac-account.pl to use KohaDates TT plugin Created attachment 8282 [details] [review] Update opac-tags.pl to use KohaDates TT plugin Created attachment 8283 [details] [review] Update opac-user.pl to use KohaDates TT plugin Created attachment 8284 [details] [review] Update opac-detail.pl to use KohaDates TT plugin Created attachment 8285 [details] [review] Update sco/sco-main.pl to use KohaDates TT plugin Created attachment 8286 [details] [review] Update opac-userupdate.pl to use KohaDates TT plugin Created attachment 8287 [details] [review] Update opac-showreviews.pl to use KohaDates TT plugin Created attachment 8288 [details] [review] Update opac-readingrecord.pl to use KohaDates TT plugin To test, just apply a patch, and go to the modified page. If dates are still displayed correctly, then you can signoff the patch Created attachment 8573 [details] [review] [SIGNED-OFF] Bug 7743: Update opac-account.pl to use KohaDates TT plugin Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Created attachment 8574 [details] [review] [SIGNED-OFF] Bug 7743: Update opac-tags.pl to use KohaDates TT plugin Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Created attachment 8575 [details] [review] [SIGNED-OFF] Bug 7743: Update opac-user.pl to use KohaDates TT plugin Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> fixed conflict Created attachment 8576 [details] [review] [SIGNED-OFF] Bug 7743: Update opac-detail.pl to use KohaDates TT plugin Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> fixed conflict Created attachment 8577 [details] [review] [SIGNED-OFF] Bug 7743: Update sco/sco-main.pl to use KohaDates TT plugin Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Created attachment 8578 [details] [review] [SIGNED-OFF] Bug 7743: Update opac-userupdate.pl to use KohaDates TT plugin Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Created attachment 8579 [details] [review] [SIGNED-OFF] Bug 7743: Update opac-showreviews.pl to use KohaDates TT plugin Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> Created attachment 8580 [details] [review] [SIGNED-OFF] Bug 7743: Update opac-readingrecord.pl to use KohaDates TT plugin Signed-off-by: Marijana Glavica <mglavica@ffzg.hr> fixed conflict Created attachment 8624 [details] [review] Bug 7743 followup: fix use of removed formattedwaitingdate param in opac-user.tt Replaces formattedwaitingdate with just waitingdate, since no longer create and export that template variable opac-account.pl: Passed QA opac-tags.pl: Passed QA opac-user.pl: Still depends on formattedwaitingdate in an IF conditional, which is removed from the template params. opac-detail.pl: Passed QA sco/sco-main.pl: Passed QA opac-userupdate.pl: Passed QA opac-showreviews.pl: Passed QA opac-readingrecord.pl: as far as I can tell, this depends on the opac-user.pl patch and the opac-detail.pl patch, doing some followup cleaning on them. Looks safe, so marking as Passed QA. My appended patch is designed to fix the issue with opac-user.pl. With that patch in place, I can mark this all as Passed QA. ok in master Created attachment 9038 [details] [review] Bug 7743 follow up fixing syntax to so templates pass test Created attachment 9041 [details] [review] [SIGNED-OFF] Bug 7743 follow up fixing syntax to so templates pass test Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Failing test was: xt/author/valid-templates.t follow-up needed because patch 3a0b35cfbca53c347869df7823cfff879fffa73d (bug 2780) replaced the USE KohaDates by a use KohaDates ok in master, marked as resolved. |