| Summary: | Use of date filters in basket pages | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Adrien SAURAT <adrien.saurat> |
| Component: | Acquisitions | Assignee: | Adrien SAURAT <adrien.saurat> |
| Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | koha, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: | proposed patch #1 | ||
|
Description
Adrien SAURAT
2012-03-19 15:01:37 UTC
Created attachment 8297 [details] [review] proposed patch #1 Dates on basket.pl and neworderempty.pl are now handled with TT date filters. *** Notes *** (which may lead to new bug creations) 1) In basket.pl I totally removed the following line : entrydate => C4::Dates->new($results[0]->{'entrydate'},'iso')->output as entrydate doesn't seem to be used (anymore?) 2) Also, in the same page, the block about ( $op eq 'del_basket') is never reached as far as I can tell. If a basket is deleted we only go through the "delete_confirm" operation, don't we? I have tested with a sandbox. Everything seems to work. I don't really know if i should see a change in the date appearence (I see no change in fact). I can delete a basket without problems. You shouldn't see any change indeed. We are keeping the same functionality, it's just coded in a more efficient way.
But the whole basket and neworderempty pages have to remain functional. I should have written a test plan.
Here it is :
=== TEST PLAN ===
All dates must be displayed in the format selected in the"dateformat" system preference.
I would be for example "dd/mm/yyyy" for a french library, but "yyyy-mm-dd" for others (US I think).
1) If you list your vendors and select a basket (which has been closed), you should see on the basket page 2 dates like this (if your "dateformat" system preference is set to "dd/mm/yyyy") :
Opened on: 11/01/2012
Closed on: 01/02/2012
2) If you are on an open basket (you can reopen the last one), you can "Add order to basket". If you do this from a new (empty) record, you arrive on the neworderempty.pl page.
On this page, the creation date of the order is displayed, like this :
Open on: 11/01/2012
Again, it depends on the dateformat syspref, so if you are configured with "yyyy-mm-dd", you should see :
Open on: 2012-01-11
=================
Thanks for taking the time to sign this.
When it will come to QA, I'd like to have a confirmation that this "entrydate" deletion is not harmful in any way. It seems obsolete to me but I may have missed something.
Safely removes format_date from those two pages, as well as the unused entrydate template param. Marking as Passed QA. (if date filters have been pushed to 3.6, this patch can be applied safely) |