Summary: | claim mail is not sent for serial claim | ||
---|---|---|---|
Product: | Koha | Reporter: | jmbroust <jean-manuel.broust> |
Component: | Serials | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | blocker | ||
Priority: | P5 - low | CC: | paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Bug Depends on: | 5342, 5347 | ||
Bug Blocks: | |||
Attachments: |
Bug 7756: FIX send email for late orders
[SIGNED-OFF] Bug 7756: FIX send email for late orders |
Description
jmbroust
2012-03-20 11:42:21 UTC
I retested on current master and the logs show this message without the patch from 5342 - the bug is not related to the feature itself. It's broken in general. [Mon Apr 09 08:45:09 2012] [error] [client 127.0.0.1] [Mon Apr 9 08:45:09 2012] claims.pl: Use of uninitialized value in concatenation (.) or string at /home/katrin/kohaclone/C4/Letters.pm line 340., referer: http://localhost:8080/cgi-bin/koha/serials/claims.pl [Mon Apr 09 08:45:09 2012] [error] [client 127.0.0.1] [Mon Apr 9 08:45:09 2012] claims.pl: Bookseller without emails at /home/katrin/kohaclone/C4/Letters.pm line 340., referer: http://localhost:8080/cgi-bin/koha/serials/claims.pl Created attachment 9066 [details] [review] Bug 7756: FIX send email for late orders Hi Jonathan, thank you for your patch! I will test asap! Hi Jonathan, 1) The claim counter only increases, when an email for the vendor is set and a success is reported. So that's good! 2) From other tests, I had deleted my email address from the patron, the branch and KohaAdminEmailAdress. So when I claimed, no email was generated and I got the following error in the logs: [Tue Apr 10 21:28:29 2012] [error] [client 127.0.0.1] [Tue Apr 10 21:28:29 2012] lateorders.pl: Bad or missing From address: '', referer: http://localhost:8080/cgi-bin/koha/acqui/lateorders.pl [Tue Apr 10 21:28:29 2012] [error] [client 127.0.0.1] [Tue Apr 10 21:28:29 2012] lateorders.pl: at /home/katrin/kohaclone/acqui/lateorders.pl line 83, referer: http://localhost:8080/cgi-bin/koha/acqui/lateorders.pl It would be great, if there was an error message for a missing from address as there is one for missing vendor address now. After I fixed the emails - mail was sent out :) 3) I noticed a little new problem, that is not urgent: The order date ___ days ago filter has no value set, so when you filter on vendor without putting in a value or if you send claim letters, a red error message shows up: The number of days () must be a number between 0 and 999. Perhaps with a default value of 0 this would work? I am signing off as this patch fixes 2 problems: - sending mail now works again - claim counter is not increased when vendor had no email addres Hm, I think this is the bug for serial claims, but the patch is for late order claims... ? Created attachment 9090 [details] [review] [SIGNED-OFF] Bug 7756: FIX send email for late orders Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - sending claim mails works now - claim counter is not increased when vendor has no email address Adds booksellerid back to the Alert SQL, and does some better checking for existence of things before using them. Marking Passed QA. (In reply to comment #4) > 3) I noticed a little new problem, that is not urgent: The order date ___ > days ago filter has no value set, so when you filter on vendor without > putting in a value or if you send claim letters, a red error message shows > up: The number of days () must be a number between 0 and 999. > Perhaps with a default value of 0 this would work? Hi Katrin, I can't reproduce this problem. On the late orders page, I select a vendor and click on the filter button. I don't have the error message. Ok, fixed (I hope) in the last submitted patch for Bug 5347 Sending serial claims now works for me and I have signed off on the patch on bug 5347 that fixes problems with late order claims. I am marking this bug resolved to end the confusion. If we find more problems with serial claims, those can go on separate bugs. |