| Summary: | reports/bor_issues_top.pl: we need to exit(0) for plack | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Dobrica Pavlinusic <dpavlin> |
| Component: | Reports | Assignee: | Dobrica Pavlinusic <dpavlin> |
| Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | alex.arnaud, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7829 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 7172 | ||
| Attachments: |
proposed patch
Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack [Signed-off] Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack |
||
|
Description
Dobrica Pavlinusic
2012-03-21 10:24:33 UTC
Comment hidden (obsolete)
Created attachment 8424 [details] [review] Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack Created attachment 8557 [details] [review] [Signed-off] Bug 7772 - reports/bor_issues_top.pl: we need to exit(0) for plack Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> It works, signing off This exit(1) line looks to be very, very old code, and I don't think an error exit status is at all appropriate, given that the code did exactly what it was supposed to do. Marking Passed QA. Further investigation shows that the whole reports area is littered with exit(1) for cases of success. A wider-range patch to fix all these instances is welcomed. There have been no further reports of problems so I am marking this bug resolved. |