Summary: | Tiny problems with calling GetShelf | ||
---|---|---|---|
Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
Component: | Lists | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Patch for unused calls
Patch for unused calls Patch for addbybiblio scripts Bug 7788: Patch for unused calls Bug 7788: Patch for addbybiblio scripts |
Description
Marcel de Rooy
2012-03-22 09:24:11 UTC
Created attachment 8477 [details] [review] Patch for unused calls Removed two unused calls. Initialized $output in downloadshelf. Corrected some confusing indentation in downloadhself too. Created attachment 8478 [details] [review] Patch for unused calls Removed a whitespace warning Second patch resolves incorrect call to GetShelf in opac and staff in addbybiblionumber script. It was and is harmless, because the singlecategory variable was not really used (the category$x param was ignored in the template). Just a cleanup operation. Created attachment 8481 [details] [review] Patch for addbybiblio scripts Patch resolves incorrect call to GetShelf in opac and staff. It was and is harmless, because the singlecategory variable was not really used (the category$x param was ignored in the template). Just a cleanup operation. Created attachment 9508 [details] [review] Bug 7788: Patch for unused calls Cleaning code. Signed off Created attachment 9509 [details] [review] Bug 7788: Patch for addbybiblio scripts Fix returns for GetShelf QA comments: tiny patches, remove some useless code, passed QA code cleaning that can be applied to 3.8 or not, at RMaint option ! Harmless tidy ups, pushed to 3.8.x will be in release 3.8.2 |