Bug 7807

Summary: GetSuggestionFromBiblionumber takes only one parameter
Product: Koha Reporter: Julian Maurice <julian.maurice>
Component: Architecture, internals, and plumbingAssignee: Julian Maurice <julian.maurice>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: normal    
Priority: P3 CC: jonathan.druart, paul.poulain
Version: 3.8   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Fix call to GetSuggestionFromBiblionumber
Bug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber

Description Julian Maurice 2012-03-22 16:19:03 UTC
GetSuggestionFromBiblionumber takes only one parameter (biblionumber) but C4::Acquisitions::ModReceiveOrder call it with $dbh in first parameter which can cause undesirable effects.
Comment 1 Julian Maurice 2012-03-22 16:22:50 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2012-04-06 11:42:28 UTC
Created attachment 8946 [details] [review]
Bug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber

the $dbh param is not required by GetSuggestionFromBiblionumber
Comment 3 Ian Walls 2012-04-06 22:13:10 UTC
It's true, it does only take the one param.  Easy one line fix, marking as Passed QA.
Comment 4 Paul Poulain 2012-04-10 09:58:02 UTC
I think this problem is only on 3.8 (unchecked)
Comment 5 Julian Maurice 2012-04-12 08:06:19 UTC
Ok in master.