Bug 7816

Summary: use encoding(UTF-8) not utf-8 for output streams
Product: Koha Reporter: Colin Campbell <colin.campbell>
Component: Architecture, internals, and plumbingAssignee: Colin Campbell <colin.campbell>
Status: CLOSED FIXED QA Contact: Ian Walls <koha.sekjal>
Severity: minor    
Priority: P5 - low CC: jonathan.druart+koha, paul.poulain
Version: 3.8   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 6679    
Bug Blocks:    
Attachments: Proposed Patch
Bug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such

Description Colin Campbell 2012-03-23 14:12:31 UTC
Setting :utf-8 on output streams flags the stream as unicode but does not ensure output is encoded as such using ':encoding(UTF-8) is the correct call.

Fixed already in most files authorities/ysearch.pl reintroduces a case of not using encoding and causes make test to fail if TEST_QA is set
Comment 1 Colin Campbell 2012-03-23 14:14:35 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2012-04-06 11:50:25 UTC
Created attachment 8947 [details] [review]
Bug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such

Before the patch:
% perlcritic authorities/ysearch.pl
I/O layer ":utf8" used at line 38, column 1.  Use ":encoding(UTF-8)" to get strict validation.  (Severity: 5)

% perlcritic authorities/ysearch.pl
authorities/ysearch.pl source OK
Comment 3 Ian Walls 2012-04-06 22:15:20 UTC
Encoding fix to authorities/ysearch.pl.  Marking Passed QA
Comment 4 Jared Camins-Esakov 2012-12-31 00:55:52 UTC
There have been no further reports of problems so I am marking this bug resolved.