Description
Galen Charlton
2012-03-23 21:07:47 UTC
As of now, http://git.koha-community.org/gitweb/?p=wip/koha-equinox.git;a=shortlog;h=refs/heads/dom-biblio contains code to add support for DOM indexing equivalent to the current GRS-1 filter's support for MARC21 with the improvement that indexed phrases can cross subfield boundaries. Although it's a little early, given timing I'm marking the branch as of today as needs signoff to encourage testing. I tested it, and ran into an issue with the relevancy ranking. The translation of the following lines is problematic: melm 243$n Thematic-number melm 243$r Music-key melm 243 Title:w,Title:p,Title-collective melm 245$a Title-cover:w,Title-cover:p,Title-cover:s,Title:w,Title:p,Title:s melm 245$c Author,Author-in-order:w,Author-in-order:p,Author-in-order:s melm 245$9 Cross-Reference:w,Koha-Auth-Number melm 245 Title:w,Title:p (I kept the 243 lines for comparison sake, the issue is really with 245, as explained below) In particular, note that 245$c in the GRS-1 configuration does *not* get put into the Title index. In C4::Search, hits in the Title index are marked as r3, which (under GRS-1) ignores the statement of responsibility in 245$c. With the conversion of record.abs to DOM indexes, the Title:w, Title:p indexes now include the statement of responsibility, which means that authors' names will be given r3 ranking, *plus* the additional weighting for appearing additional times elsewhere in the record. Also, XML reindexing still doesn't work with DOM: Entity: line 87: parser error : XML declaration allowed only at the start of the document <?xml version="1.0" encoding="UTF-8"?> ^ Entity: line 88: parser error : Extra content at the end of the document <record ^ 16:42:05-28/03 zebraidx(8685) [warn] extract error: generic (In reply to comment #2) > In particular, note that 245$c in the GRS-1 configuration does *not* get put > into the Title index. In C4::Search, hits in the Title index are marked as > r3, which (under GRS-1) ignores the statement of responsibility in 245$c. > With the conversion of record.abs to DOM indexes, the Title:w, Title:p > indexes now include the statement of responsibility, which means that > authors' names will be given r3 ranking, *plus* the additional weighting for > appearing additional times elsewhere in the record. My inclination would be to add a "title-rel" index to the index config that includes (say) the 245$a and $b and have that be used for the hard-coded relevance ranking, with suitable shimming to leave GRS-1-based configs unaffected. Thoughts? (In reply to comment #4) > (In reply to comment #2) > > In particular, note that 245$c in the GRS-1 configuration does *not* get put > > into the Title index. In C4::Search, hits in the Title index are marked as > > r3, which (under GRS-1) ignores the statement of responsibility in 245$c. > > With the conversion of record.abs to DOM indexes, the Title:w, Title:p > > indexes now include the statement of responsibility, which means that > > authors' names will be given r3 ranking, *plus* the additional weighting for > > appearing additional times elsewhere in the record. > > My inclination would be to add a "title-rel" index to the index config that > includes (say) the 245$a and $b and have that be used for the hard-coded > relevance ranking, with suitable shimming to leave GRS-1-based configs > unaffected. Thoughts? +1 from me. I'd suggest adding title-rel to record.abs, and just adjust the r3 configuration for all installations. (In reply to comment #3) > Also, XML reindexing still doesn't work with DOM: > > > Entity: line 87: parser error : XML declaration allowed only at the start of > the document > <?xml version="1.0" encoding="UTF-8"?> > ^ > Entity: line 88: parser error : Extra content at the end of the document > <record > ^ > 16:42:05-28/03 zebraidx(8685) [warn] extract error: generic I've pushed an update to the dom-biblio branch to now make this work. (In reply to comment #5) > +1 from me. I'd suggest adding title-rel to record.abs, and just adjust the > r3 configuration for all installations. I decided to back off from doing that to avoid the potential for forcing *all* users to reindex their bibs upon upgrade to 3.8. I've pushed a compromise of using Title-cover,phr as the r3 weighted part of the default relevance search. After testing (thanks Jared!), a revised branch for signoff is now available in the wip/koha-equinox.git repository, branch bug7818-dom-biblio-final. Created attachment 8965 [details] [review] Bug 7818: update installer for biblio DOM indexing Adds the necessary bits to enable DOM indexing for bib records as an option during installation from source. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8966 [details] [review] Bug 7818: update miscellaneous installer scripts Teach a couple of the quick-install scripts about DOM mode for bibs. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8967 [details] [review] Bug 7818: utility to generate DOM indexing configs misc/maintenance/make_zebra_dom_cfg_from_record_abs: generate a DOM filter Zebra index config from a GRS-1 config Given a Zebra record.abs file containing a set of index definitions for Zebra's GRS-1 filter, write an equivalent DOM filter configuration. To generate the XSLT that is to be used by Zebra, run something like the following on the output of this utility: xsltproc ZEBRA_CFG_DIR/xsl/koha-indexdefs-to-zebra.xsl \ biblio-koha-indexdefs.xml \ > ZEBRA_CFG_DIR/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl The above example assumes that the output of the program was named biblio-koha-indexdefs.xsl. This commit also introduces Koha::Indexer::Utils, a new package for misceallenous routines that support Koha's indexing definitions. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8968 [details] [review] Bug 7818: move koha-indexdefs-to-zebra.xsl Since the koha-indexdefs-to-zebra.xsl stylesheet will be used by both bib and authority indexing, put in a central location. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8969 [details] [review] Bug 7818: add index_data_field option to DOM indexing repertoire Adds a new kohaidx:index_data_field index definition type which indexes all of the subfields of a MARC data field as a single phrase, separating the contents of each with a space. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8970 [details] [review] Bug 7818: Zebra DOM filter index definitions for MARC21 bibs The file biblio-zebra-indexdefs.xsl, which is the stylesheet that is used by the Zebra DOM filter to convert an incoming MARC21 bib to its indexed form, was generated by the following two steps: misc/maintenance/make_zebra_dom_cfg_from_record_abs \ --input etc/zebradb/marc_defs/marc21/biblios/record.abs \ --output etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl \ etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml \ > etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl Records indexed using this XSLTshould behave similarly to records indexed using the GRS-1 filter and the old record.abs definition, with the following big exception (and improvemwent): indexed phrases now span subfield boundaries if a specific subfield wasn't specified in the index definition. For example, the GRS-1 filter index definition melm 245 Title would allow 245 $a Cats on boxes : $b cardboard fantasies to be searched as the phrases "cats on boxes" or "cardboard fantasies", but a title phrase seach of "cats on boxes cardboard fantasises" wouldn't work. The DOM filter equivalent, <index_data_field xmlns="http://www.koha-community.org/schemas/index-defs" tag="245"> <target_index>Title:w</target_index> <target_index>Title:p</target_index> </index_data_field> *does* allow phrase searches to span subfield boundaries. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8971 [details] [review] Bug 7818: -x option of rebuild_zebra.pl now works with DOM filter One consequence is that the -x and -a options are no longer mutually exclusive. Also, because of the way that the GRS-1 SGML filter works, if you're indexing multiple documents, you can't just wrap them in a document element, but the DOM filter *requires* it. Consequently, two new config settings in koha-conf.xml are added to indicate the Zebra filter in use so that the -x option of rebuild_zebra.pl knows whether to wrap the exported records or not: - bib_index_mode (defaults to 'grs1' if not specified) - auth_index_mode (defaults to 'dom') Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8972 [details] [review] Bug 7818: use Title-cover for title phrase weighting This is offerred as a compromise alternative to creating a new Title-rel index to avoid having the statement of responsiblity unduly affect field weight when using the DOM filter and MARC21 -- the problem with creating a Title-rel index is that it would *force* reindexing upon upgrade. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8973 [details] [review] Bug 7818: update comment to clarify availability of DOM index mode DOM indexing is now available for both bibs and authorities. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 8974 [details] [review] Bug 7818: add warning about not editing record.abs when using DOM filter This commit also updates the authority and biblio DOM indexing definition XSL to include updated header comments. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Both "traditional" GRS-1-mode indexing and DOM-mode indexing work perfectly with these patches, so I recommend the feature for inclusion in 3.8, as it does not change existing behavior. Here is a summary for documentation purposes of the patches that have been signed off: This is a series of patches implementing DOM-filter indexing for bibliographic records. Currently this series of patches does the following: [1] Adds a Makefile.PL option to enable DOM filter indexing [2] Adds a utility for converting a record.abs index definitions to DOM-style definitions [3] Includes DOM-style index definitions for MARC21 bibs that are equivalent to the legacy record.abs, with the exception that phrases can span subfield boundaries. To test this on an existing database, some variation of the following procedure should work: [1] perl Makefile.PL and choose to enable DOM indexing of bibs [2] If the index defintions have been customized, use make_zebra_dom_cfg_from_record_abs and the koha-indexdefs-to-zebra.xsl stylesheet to generate a an updated biblio-zebra-indexdefs.xsl [3] make [4] make update_zebra_conf This patch series also includes the following related changes: [1] The -a and -x options to rebuild_zebra.pl are no longer mutually exclusive. [2] The title phrase rank 3 field weight has been replaced by Title-cover. This prevents a side effect of DOM indexing (where the DOM-filter equivalent of record.abs melm XXX indexes the entire field as a unit, not each subfield separately) from given the statement of responsibility in the 245$c undue weight in relevance ranking. [3] Some comments were added regarding the potential future deprecation of the use of Zebra's GRS-1 filter. QA: It works as described for a MARC21 DB. I will try now with UNIMARC DB after generating DOM biblios def. Created attachment 8982 [details] [review] UNIMARC DOM It works with UNIMARC also (In reply to comment #22) > Created attachment 8982 [details] [review] > UNIMARC DOM > > It works with UNIMARC also one more sign-off on Frédéric's patch with UNIMARC, and i'll pass-QA on it :) ps: Galen, it looks very good! Created attachment 9798 [details] [review] Bug 7818 Add UNIMARC biblio records zebra DOM def files Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> I tested two UNIMARC Koha installations using the sample UNIMARC data from the BibLibre sandbox, comparing the results with DOM and with GRS-1 indexing. The results are very similar, though there are some differences. Most noticeable: * relevance and facets seem to be more accurate with DOM enabled * the GRS-1 configuration returns approximately 10% more results with random single keywords like "petit," but the DOM results contain the most relevant items, and any lacks in the configuration can easily be corrected as UNIMARC users identify fields that should be indexed but aren't * authority-controlled searches match exactly * author and topic facets do not work with the out-of-the-box GRS-1 indexing configuration (?!?) (adding second sign-off line below because all that probably looks like a commit message and not a sign off) Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Please QA fast - waiting for this to get in! :) >> one more sign-off on Frédéric's patch with UNIMARC, and i'll pass-QA on it :) > Bug 7818 Add UNIMARC biblio records zebra DOM def files > > Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> sign-off for the last patch has been completed all patches pass 'perlcritic' and 'prove xt' tests i think this awesome feature just passed-QA! :) > all patches pass 'perlcritic' and 'prove xt' tests
fyi: all patches applied clean to 722ca127dd0aaf0646001594ebbece18c75d12b1
I've tested this patch, and after some pain understanding which files I must put where, I succeded. Just a comment, I get a nasty error when using the -x flag: 18:22 ~/koha.dev/installs/lecannetdesmaures/etc$ ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v -x --offset=100 --length=10 -r Entity: line 84: parser error : Extra content at the end of the document <record ^ 18:23:08-06/06 zebraidx(11130) [warn] extract error: generic When indexing without -x, things are OK (~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v --offset=100 --length=10 -r ) I can't make it work properly, so I need to understand what I made wrong... Here are the steps I followed on an existing (UNIMARC) setup: * Edit etc/zebradb/zebra-biblios.cfg file: - update profilePath: line by appending xsl path: :$KOHA/etc/zebradb/xsl - comment the following line: marcxml.recordType:grs.sgml - add after the commented line: recordtype: dom.$KOHA/etc/zebradb/biblios/etc/dom-config.xml marcxml.recordtype: dom.$KOHA/etc/zebradb/biblios/etc/dom-config.xml iso2709.recordtype: dom.$KOHA/etc/zebradb/biblios/etc/dom-config-marc.xml - if your $KOHA setup is not where your koha code is, you must copy 2 new files: cp $KOHAGIT/etc/zebradb/biblios/etc/*.xml $KOHA/etc/zebradb/biblios/etc/ - generate xsl configuration: $KOHA/misc/maintenance/make_zebra_dom_cfg_from_record_abs --input $ZEBRADIR/zebradb/marc_defs/unimarc/biblios/record.abs --output $ZEBRADIR/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xml xsltproc $ZEBRADIR/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl $ZEBRADIR/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xml >zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl Once I've made that, if I try to reindex: 19:41 ~/koha.dev/installs/koha-community/etc$ ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v --offset=0 --length=10 -r -x -k Zebra configuration information ================================ Zebra biblio directory = /home/paul/koha.dev/installs/koha-community/var/lib/zebradb/biblios Zebra authorities directory = /home/paul/koha.dev/installs/koha-community/var/lib/zebradb/authorities Koha directory = /home/paul/koha.dev/koha-community BIBLIONUMBER in : 001$@ BIBLIOITEMNUMBER in : 090$a ================================ skipping authorities ==================== exporting biblio ==================== 1......... Records exported: 10 ==================== REINDEXING zebra ==================== Entity: line 741: parser error : Extra content at the end of the document <record ^ 19:43:10-06/06 zebraidx(12791) [warn] extract error: generic ==================== CLEANING ==================== I've checked that the XML file looks good, it does. If I remove the -x flag, it works. Any help/hint welcomed, I spent a lot of time on this setup, and will continue Trying the -x and --nosanitize flags, I get another error: 19:55 ~/koha.dev/installs/koha-community/etc$ ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v --offset=0 --length=10 -r -x -k --nosanitize Zebra configuration information <snope> ==================== REINDEXING zebra ==================== Entity: line 742: parser error : XML declaration allowed only at the start of the document <?xml version="1.0" encoding="UTF-8"?> ^ 19:55:27-06/06 zebraidx(13014) [warn] extract error: generic > 18:22 ~/koha.dev/installs/lecannetdesmaures/etc$
> ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v
> -x --offset=100 --length=10 -r Entity: line 84: parser error : Extra
> content at the end of the document
I think it means that the file containing the exported marcxml biblio is
not a valid XML file. <collection> </collection> is missing. Try to add
it by hand, and reindex directly with zebraidx.
Created attachment 9968 [details] [review] Bug 7818 Fix rebuild_zebra.pl --nosanitize (In reply to comment #31) > > 18:22 ~/koha.dev/installs/lecannetdesmaures/etc$ > > ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v > > -x --offset=100 --length=10 -r Entity: line 84: parser error : Extra > > content at the end of the document > > I think it means that the file containing the exported marcxml biblio is > not a valid XML file. <collection> </collection> is missing. Try to add > it by hand, and reindex directly with zebraidx. OK, seems you're right Frederic: zebraidx -c /home/paul/koha.dev/installs/koha-community/etc/zebradb/zebra-biblios.cfg -g marcxml -d biblios update /tmp/kUzN0iLpkp/biblio/ => without changing anything to /tmp/kUzN0iLpkp/biblio/ I get Entity: line 741: parser error : Extra content at the end of the document <record ^ 20:18:38-06/06 zebraidx(13191) [warn] extract error: generic => after adding <collection> and </collection> I get: 20:20:26-06/06 zebraidx(13208) [log] update dom./home/paul/koha.dev/installs/koha-community/etc/zebradb/biblios/etc/dom-config.xml /tmp/kUzN0iLpkp/biblio/exported_records 102404 20:20:26-06/06 zebraidx(13208) [log] Iterations: isam/dict 1808/1803 20:20:26-06/06 zebraidx(13208) [log] Dict: inserts/updates/deletions: 901/0/902 20:20:27-06/06 zebraidx(13208) [log] Records: 10 i/u/d 0/10/0 So the NEXT QUESTION is = why is'nt the <collection> included automatically (as it used to be) Looking at the code, it's clearly related to sub include_xml_wrapper {} This sub should return 1 and return 0. It should return 1 from this line: return 1 if $record_type eq 'biblio' and $bib_index_mode eq 'dom'; The $bib_index_mode is set by: my $bib_index_mode = C4::Context->config('zebra_bib_index_mode') || 'grs1'; looking at my configuration file... There is no <zebra_bib_index_mode>__BIB_INDEX_MODE__</zebra_bib_index_mode> adding it.... and it works, with the exception of a warning i'll investigate later, but if you have an idea, let me know ! 20:27:55-06/06 zebraidx(13358) [warn] Unknown register type: (nothing after the "register type:") Trying to search, I get no results, but a nasty Can't call method "data" on an undefined value at /home/paul/koha.dev/koha-community/C4/Search.pm line 1496. Adding a warning in the code, I see: DUMP$VAR1 = bless( { '_fields' => [], '_leader' => ' ', '_warnings' => [ 'Record length "" is not numeric in record 1' ] }, 'MARC::Record' ); Adding the following lines that are missing in the koha-conf.xml: <!-- <maximumrecordsize>2000000</maximumrecordsize> --> <xi:include href="/home/paul/koha.dev/installs/lecannetdesmaures/etc/zebradb/retrieval-info-bib-dom.xml" xmlns:xi="http://www.w3.org/2001/XInclude"> <xi:fallback> <retrievalinfo> and </xi:fallback> </xi:include> after the </retrievalinfo> The result is the same: zebra log file says: 12:27:16-07/06 zebrasrv(1) [session] Session - OK 1 unix:/home/paul/koha.dev/installs/lecannetdesmaures/var/run/zebradb/bibliosocket 19584 12:27:16-07/06 zebrasrv(1) [request] Auth idPass kohauser - 12:27:16-07/06 zebrasrv(1) [request] Init OK - ID:81 Name:ZOOM-C/YAZ Version:4.2.18 cc3abee6f861d0166bef5333b1fc72fbdc8bd94c 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [log] dict_lookup_grep: (\x01\x02)(j(e|\xC3\xA9|\xC3\xA8|\xC3\xAA|\xE1\xBA\xBD|\xC4\x95|\xC4\x99|\xC4\x97|\xC4\x9B|\xC8\x85|\xC8\x87)(a|\xC3\xA1|\xC3\xA0|\xC3\xA3|\xC3\xA5|\xC3\xA2|\xC4\x83|\xC4\x85|\xC8\xA7|\xC7\x8E|\xC8\x81|\xC8\x83)n) 12:27:16-07/06 zebrasrv(1) [request] Search biblios OK 1 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 jean 12:27:16-07/06 zebrasrv(1) [log] /home/paul/koha.dev/koha-community/etc/zebradb/biblios/etc/dom-config.xml dom filter: loading config file /home/paul/koha.dev/koha-community/etc/zebradb/biblios/etc/dom-config.xml 12:27:16-07/06 zebrasrv(1) [request] Present OK - 1 1+1 12:27:16-07/06 zebrasrv(1) [session] Connection closed by client Checking what zebrasrv says when you launch it, I see: I/O warning : failed to load external entity "/home/paul/koha.dev/installs/lecannetdesmaures/etc/zebradb/retrieval-info-bib-dom.xml" the file is not here, copying it at the right place (from $KOHA/etc/zebradb/) it works ! will summarize all my tests in a wiki page: "switching to DOM indexing when you have Koha already running" ! PAtch pushed, and http://wiki.koha-community.org/wiki/Switching_to_dom_indexing created. It's a big & major patch, I'll call for more testers on koha-devel immediatly I'm going to pull this back into 3.8.x now, it is a no risk change, that does nothing unless you specifically enable it. It's bordering on more of a bug fix than an enhancement as it fixes some fairly serious bugs in searching. So I want to let libraries take advantage of it if they wish. Pushed to 3.8.x, contains no database changes and makes no changes to anything on upgrade. But allows new libraries to use DOM indexing for biblios, or existing libraries to choose to upgrade to it. Searching works well, indexing is fast. Will be in 3.8.3 We now need a patch to fix the packaging. dh_install: etc/koha/zebradb/zebra-biblios-dom.cfg exists in debian/tmp but is not installed to anywhere git/catalyst-koha/debian% ls templates apache-shared.conf apache-site.conf.in zebra-authorities-site.cfg.in apache-shared-disable.conf koha-conf-site.xml.in zebra-biblios-site.cfg.in apache-shared-intranet.conf SIPconfig.xml zebra.passwd.in apache-shared-opac.conf zebra-authorities-dom-site.cfg.in Created attachment 10560 [details] [review] Bug 7818 : Following, fixing so the packages build Still need to update koha-create to make use of the new file Patch to allow the packages to build. Still needs another followup to make use of the dom config, but at least now the packages can build Created attachment 10617 [details] [review] Bug 7818 : Following, fixing so the packages build Still need to update koha-create to make use of the new file Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> (In reply to comment #42) > Created attachment 10617 [details] [review] > Bug 7818 : Following, fixing so the packages build Still need to update > koha-create to make use of the new file > > Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Passing-QA on this patch applies clean to master 'ce138ac96f3a5a729568f6d7db2e50ce3653b7bb' Follow-up for packages pushed Follow up pushed to 3.8.x An idea from bug 3087: > Actually, I would recommend to just delete the retrieval fallback > section in koha-conf.xml. Now we have a confusing situation; fallback > within the same etc directory does not make much sense to me. The retrieval sections are now in separate files in etc/zebradb. Fallback is in etc/koha-conf.xml. Can we simplify this and eliminate confusion? Another dumb question: When I reindex zebra (marc21 dom) on current master, I have this warning: 14:54:01-29/08 zebraidx(23260) [warn] Unknown register type: The register type is apparently empty. This does not happen on current master with grs1. Any idea? A problem with the definitions xml? |