Summary: | reports/ remove all exit(1) for plack | ||
---|---|---|---|
Product: | Koha | Reporter: | Dobrica Pavlinusic <dpavlin> |
Component: | Reports | Assignee: | Dobrica Pavlinusic <dpavlin> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | alex.arnaud, m.de.rooy, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7772 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8833 |
||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 7829 - reports/ remove all exit(1) for plack
[Signed-off] Bug 7829 - reports/ remove all exit(1) for plack |
Description
Dobrica Pavlinusic
2012-03-26 14:48:25 UTC
Created attachment 8632 [details] [review] Bug 7829 - reports/ remove all exit(1) for plack In Bug 7772 Ian correctly noted that reports have exit(1) all over the place. This is left over from old code, and this patch changes them to exit(0). I decided to use plain exit as opposed to explicit exit(0) since it produces cleaner code, but I'm welcoming suggestion on this. Having koha on plack, i tested making reports such as acquisitions_stats.pl, reserves_stats.pl, issues_stats.pl etc ... and got Internal Server Error on each script when submitting the form. The patch fix this problem. So signing off Created attachment 8644 [details] [review] [Signed-off] Bug 7829 - reports/ remove all exit(1) for plack In Bug 7772 Ian correctly noted that reports have exit(1) all over the place. This is left over from old code, and this patch changes them to exit(0). I decided to use plain exit as opposed to explicit exit(0) since it produces cleaner code, but I'm welcoming suggestion on this. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> QA Comment: Hope you got them all ;) Passed QA. There have been no further reports of problems so I am marking this bug resolved. |