| Summary: | circ/circulation.pl plack scoping | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marijana Glavica <mglavica> |
| Component: | Circulation | Assignee: | Dobrica Pavlinusic <dpavlin> |
| Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | alex.arnaud, dpavlin, gmcharlt, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 7172 | ||
| Attachments: |
Bug 7851 - circ/circulation.pl plack scoping
[Signed-off] Bug 7851 - circ/circulation.pl plack scoping |
||
|
Description
Marijana Glavica
2012-03-29 22:19:12 UTC
Variable "$totalprice" is not available at /srv/koha/circ/circulation.pl line 448. Variable "%renew_failed" is not available at /srv/koha/circ/circulation.pl line 456. Variable "$todaysdate" is not available at /srv/koha/circ/circulation.pl line 458. Variable "@todaysissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@relissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@previousissues" is not available at /srv/koha/circ/circulation.pl line 461. Variable "@relprevissues" is not available at /srv/koha/circ/circulation.pl line 461. Subroutine build_issue_data redefined at /srv/koha/circ/circulation.pl line 422. Created attachment 8723 [details] [review] Bug 7851 - circ/circulation.pl plack scoping Errors: Variable "$totalprice" is not available at /srv/koha/circ/circulation.pl line 448. Variable "%renew_failed" is not available at /srv/koha/circ/circulation.pl line 456. Variable "$todaysdate" is not available at /srv/koha/circ/circulation.pl line 458. Variable "@todaysissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@relissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@previousissues" is not available at /srv/koha/circ/circulation.pl line 461. Variable "@relprevissues" is not available at /srv/koha/circ/circulation.pl line 461. Test scenario: 1. go to circulation page 2. verify errors in console output of plack 3. apply patch 4. reload and verify that errors are gone 1. go to circulation page
2. verify errors in console output of plack
=> yes many errors as described in comment 2
3. apply patch
4. reload and verify that errors are gone
Errors are gone.
Also tested if it still works without plack: ok !
Signing off
Created attachment 8766 [details] [review] [Signed-off] Bug 7851 - circ/circulation.pl plack scoping Errors: Variable "$totalprice" is not available at /srv/koha/circ/circulation.pl line 448. Variable "%renew_failed" is not available at /srv/koha/circ/circulation.pl line 456. Variable "$todaysdate" is not available at /srv/koha/circ/circulation.pl line 458. Variable "@todaysissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@relissues" is not available at /srv/koha/circ/circulation.pl line 459. Variable "@previousissues" is not available at /srv/koha/circ/circulation.pl line 461. Variable "@relprevissues" is not available at /srv/koha/circ/circulation.pl line 461. Test scenario: 1. go to circulation page 2. verify errors in console output of plack 3. apply patch 4. reload and verify that errors are gone Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> more rescoping 'my' to 'our'. Fixes issues caused by the nested build_issues_data subroutine... ideally this subroutine should be removed from circ/circulation.pl (and it's hideous twin brother from members/moremember.pl), but that's a larger project than just adjusting scopes. Passed QA. There have been no further reports of problems so I am marking this bug resolved. |