Summary: | preferences.pl: cannot have choice options of yes and no | ||
---|---|---|---|
Product: | Koha | Reporter: | Srdjan Jankovic <srdjan> |
Component: | System Administration | Assignee: | Bugs List <koha-bugs> |
Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, dcook, gmcharlt, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: |
Description
Srdjan Jankovic
2012-03-30 06:12:28 UTC
I may be wrong, but if we remove the implicit type, won't that screw up pretty much every existing YesNo system preference? We would have to find every reference for every YesNo pref and change the conditional tests. No, if we explicitly type YesNo as a boolean, like Srdjan has shown, then we have to change none of the YesNo prefs. And the Choice ones will work the way they should. IE Yes becomes 1, only when it's used with a boolean field (as it should). Not sure I understand the issue, reassigning it then. It's been over 10 years, we're not using YAML::Syck anymore, I'm not sure I understand this one anyway. I think the HTML forms are based off the .pref files rather than the database, although I could be wrong. |