| Summary: | When duplicating a patron too many fields carrying over | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
| Component: | Patrons | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | cbrannon, gmcharlt, jonathan.druart, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 7878 - When duplicating a patron too many fields carrying over
[SIGNED OFF] Bug 7878 - When duplicating a patron too many fields carrying over Bug 7878 - When duplicating a patron too many fields carrying over Bug 7878: (qa follow-up) Fix the sex default value |
||
|
Description
Nicole C. Engard
2012-04-02 20:56:01 UTC
I see that gender, OPAC & Staff notes, and restrictions also carry over. I have confirmed all the Nicole has mentioned, and agree that copying the expiration is a problem. Christopher Brannon Created attachment 31903 [details] [review] Bug 7878 - When duplicating a patron too many fields carrying over When duplicating a patron the resulting entry form contains the data from the original patron in the following fields: Other names, Initials, Gender, OPAC note, Staff note, and expiration date. These should be blank for a new duplicated patron. This patch corrects this. To test, locate or create a patron record which contains data in the fields listed above. Duplicate that patron and confirm that those fields are blank in the resulting patron entry form. Confirm also that editing an existing patron with data in those fields works correctly. Created attachment 32001 [details] [review] [SIGNED OFF] Bug 7878 - When duplicating a patron too many fields carrying over When duplicating a patron the resulting entry form contains the data from the original patron in the following fields: Other names, Initials, Gender, OPAC note, Staff note, and expiration date. These should be blank for a new duplicated patron. This patch corrects this. To test, locate or create a patron record which contains data in the fields listed above. Duplicate that patron and confirm that those fields are blank in the resulting patron entry form. Confirm also that editing an existing patron with data in those fields works correctly. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Is there a reason not to use UNLESS instead of "IF do nothing ELSE do something"? (In reply to Jonathan Druart from comment #4) > Is there a reason not to use UNLESS instead of "IF do nothing ELSE do > something"? Probably not, just following the pattern already established in the template. Created attachment 32234 [details] [review] Bug 7878 - When duplicating a patron too many fields carrying over When duplicating a patron the resulting entry form contains the data from the original patron in the following fields: Other names, Initials, Gender, OPAC note, Staff note, and expiration date. These should be blank for a new duplicated patron. This patch corrects this. To test, locate or create a patron record which contains data in the fields listed above. Duplicate that patron and confirm that those fields are blank in the resulting patron entry form. Confirm also that editing an existing patron with data in those fields works correctly. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 32235 [details] [review] Bug 7878: (qa follow-up) Fix the sex default value Without the previous patch, when you edited a patron, the "N/A" value was selected for sex. With, no checkboxes were selected. This patch also replaces the IF opduplicate do nothing ELSE do something END statement with UNLESS opduplicate do something END which is more readable. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Patches pushed to master. Thanks Owen! |