Summary: | Change filename of TransferLog suggested by packages to fit with logrotate | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Packaging | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
Severity: | normal | ||
Priority: | P5 - low | CC: | paul.poulain |
Version: | 3.6 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate
Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate |
Description
Magnus Enger
2012-04-03 10:32:34 UTC
It's a weird apache default thing. I usually end up changing it manually whenever I enable the transfer log. So yes, I very much think it should be .log too. Created attachment 8856 [details] [review] Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate The apache accesslogs suggested by the default config files are called *_log, which results in them not getting picked up by logrotate, which looks for *.log. This patch changes the suggested filenames to *.log. To test: Not much to test here, just apply the patch and check that all occurences of TransferLog and CustomLog are now on the form *.log All the lines where these occur are commented out, so this will not actually change any behaviour. Created attachment 8860 [details] [review] Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate The apache accesslogs suggested by the default config files are called *_log, which results in them not getting picked up by logrotate, which looks for *.log. This patch changes the suggested filenames to *.log. To test: Not much to test here, just apply the patch and check that all occurences of TransferLog and CustomLog are now on the form *.log All the lines where these occur are commented out, so this will not actually change any behaviour. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Verified that it's totally harmless and ultimately a good thing to do. Very simple change, _ to . in several cases. If the Package Manager verifies it's safe, I'm inclined to believe. Passed QA. in fact, I even think it's not an enhancement, but a bugfix, so updating severity This patch will be included in 3.6.5. |