| Summary: | Cart missing from result lists | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Ian Walls <koha.sekjal> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, nengard, paul.poulain |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 |
| Patch complexity: | --- | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Attachments: |
[PATCH] Bug 7962 - Cart missing from result lists
[SIGNED-OFF] Bug 7962 - Cart missing from result lists Bug 7962 - Cart missing from result lists |
||
17:20 ~/kohaclone ((7eef4c8...) %|BISECTING)$ git bisect bad 7eef4c8c700dc81e8ab2fd28486162ff7db35ede is the first bad commit commit 7eef4c8c700dc81e8ab2fd28486162ff7db35ede Bug 5668 - Star ratings in the opac Excellent use of git bisect Owen! Hmmm it is now trying to load jquery twice, could that be the problem? Created attachment 9210 [details] [review] [PATCH] Bug 7962 - Cart missing from result lists Removing duplicate inclusion of jQuery on the results page which was added with the star ratings feature. Koha already uses jQuery by default. I have also made the inclusion of ratings JS and CSS dependent on ratings being turned on. Created attachment 9214 [details] [review] [SIGNED-OFF] Bug 7962 - Cart missing from result lists Removing duplicate inclusion of jQuery on the results page which was added with the star ratings feature. Koha already uses jQuery by default. I have also made the inclusion of ratings JS and CSS dependent on ratings being turned on. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Created attachment 9215 [details] [review] Bug 7962 - Cart missing from result lists Removing duplicate inclusion of jQuery on the results page which was added with the star ratings feature. Koha already uses jQuery by default. I have also made the inclusion of ratings JS and CSS dependent on ratings being turned on. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Mason James <mtj at kohaaloha.com> Template only change removes duplicate include, and conditionalizes a script and a CSS include based on actual usage. Marking Passed QA. There have been no further reports of problems so I am marking this bug resolved. |
Cart button is not shown above result lists in OPAC any longer. FireBug shows a JavaScript error: $("#cartmenulink").hoverIntent is not a function