| Summary: | Group search results tag input with other actions | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | jonathan.druart, m.de.rooy, paul.poulain |
| Version: | 3.10 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Screenshot showing proposed interface change
Bug 7980 - Group search results tag input with other actions Bug 7980: [SIGNED-OFF] Group search results tag input with other actions [PASSED_QA] Patch |
||
|
Description
Owen Leonard
2012-04-18 19:00:27 UTC
Created attachment 9247 [details]
Screenshot showing proposed interface change
Created attachment 9248 [details] [review] Bug 7980 - Group search results tag input with other actions This patch hides the tag input form in OPAC search results when TagsInputOnList is turned on. An "Add tag" is added to the "Actions" line. Clicking the link un-hides the tag input form. A "Cancel" link hides it again. The patch also moves the display of ratings to the bottom of the list so that existing tags are grouped with the other title details which are prefixed with a label ("Type:", "Availability", etc.). To test, enable the TagsInputOnList system preference. Do a search and try adding tags from the search results list. Created attachment 9417 [details] [review] Bug 7980: [SIGNED-OFF] Group search results tag input with other actions This patch is more ergonomic for tags in search results. But I think a followup is required: 1/ The 'enter' action reload the page (whereas in the opac detail, this action adds the tag). 2/ Isn't it better to clean the input after submitting ? (In reply to comment #3) > But I think a followup is required: > 1/ The 'enter' action reload the page (whereas in the opac detail, this > action adds the tag). I didn't notice this problem, but now that I'm testing I see it's a bug in master too. I'll investigate a fix for it and leave it up to QA to decide whether it should block this patch. > 2/ Isn't it better to clean the input after submitting ? I think so, but I would like to make this change in conjunction with a fix for Bug 5174. Clearing the submitted tag without offering some kind of confirmation of what tags were added seems unfriendly to me. Created attachment 9779 [details] [review] [PASSED_QA] Patch QA Comment: Looks good, works as advertised. The points Jonathan mentioned can be handled in a followup/new report. They are not really in the scope of this report, since these points already pertain to current versions of opac-results.pl / opac-tags.pl. Passed QA A valuable ENH ! |