Bug 7991

Summary:	Display in a holding summary tab information about serial record
Product:	Koha	Reporter:	delaye <stephane.delaye>
Component:	OPAC	Assignee:	Jonathan Druart <jonathan.druart>
Status:	CLOSED FIXED	QA Contact:	Ian Walls <koha.sekjal>
Severity:	enhancement
Priority:	P5 - low	CC:	chris, koha.aixmarseille, paul.poulain
Version:	3.10
Hardware:	All
OS:	All
Change sponsored?:	Sponsored	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 7991: Add itemcallnumber into the serial collection tab Bug 7991: Add itemcallnumber into the serial collection tab Bug 7991: Add itemcallnumber into the serial collection tab

Description delaye 2012-04-23 07:26:18 UTC

Display in a holding summary tab informations about serial record

branch (955$9)
holding summary (955$r)
call (930$a)

Informations imported from SUDOC

example :
http://catalogue.univ-aix-marseille.fr/cgi-bin/koha/opac-detail.pl?biblionumber=725747

Comment 1 Jonathan Druart 2012-05-03 12:59:44 UTC Comment hidden (obsolete)

Created attachment 9400 [details] [review]
Bug 7991: Add itemcallnumber into the serial collection tab


    This patch adds a new column containing the itemcallnumber value into
    the serial collection tab (opac detail).

Comment 2 Chris Cormack 2012-05-07 01:05:36 UTC

Hmm is this UNIMARC specific ? Because for MARC21 isn't the itemcallnumber in 952?

Comment 3 delaye 2012-05-07 12:28:12 UTC

after testing in a sandbox :its ok for me with the Unimarc. 
if we must apply this patch for the marc21 the fields are :

                  UNIMARC  MARC 21
callnumber ->     930$a    852$h
location   ->     955$9    852$a$b
and sub location
holding summary   955$r    863 (main collection),864 (suppl),865 (index)

Comment 4 Jonathan Druart 2012-06-21 12:20:11 UTC Comment hidden (obsolete)

Created attachment 10406 [details] [review]
Bug 7991: Add itemcallnumber into the serial collection tab

This patch adds a new column containing the itemcallnumber value into
the serial collection tab (opac detail).
  930$a for UNIMARC
  852$h for others

Comment 5 Jared Camins-Esakov 2012-08-11 16:35:55 UTC

Created attachment 11553 [details] [review]
Bug 7991: Add itemcallnumber into the serial collection tab

This patch adds a new column containing the itemcallnumber value into
the serial collection tab (opac detail).
  930$a for UNIMARC
  852$h for others

Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com>

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(Added Stephane Delaye's sign off at the same time as mine)
As this view has never worked with MARC21, I am comfortable signing
off on the fact that the patch does not in any way impact the MARC21
display.

Comment 6 Paul Poulain 2012-09-15 06:04:24 UTC

QA comment: tiny patch, passes perlcritic & koha-qa.pl

MARC21 comment(s):

* Jared, what do you mean by:
> As this view has never worked with MARC21, I am comfortable signing
> off on the fact that the patch does not in any way impact the MARC21
> display.

* Looking at the patch, I see something is added, I see:
  +      $row_data{itemcallnumber} = $marcflavour eq 'UNIMARC'
  +          ? $lc_field->subfield('a') # 930$a
  +          : $lc_field->subfield('h') # 852$h
  +          if ($sc_field->subfield('5') eq $lc_field->subfield('5'));
In MARC21, there is no $5 field, so I think this code does nothing for MARC21

As Jared says this tab does not work at all, I'm marking passed QA, but I'd like to make this tab working for MARC21 too.

Comment 7 Paul Poulain 2012-09-15 06:05:16 UTC

Patch pushed to master

I consider this is an enhancement, so for 3.10 only. It's a tiny patch that can be reverted if it appears there's a real problem for MARC21