Description
Nicole C. Engard
2012-04-30 22:41:37 UTC
Ian, are you still planning to work on this? Work to be done: 1) Modify the pickup location on holds table to be a pulldown of pickup locations 2) Add new svc/rest script to update hold pickup locations 3) Modify javascript such that change the pickup location first asks for confirmation, if change is confirmed, pickup location will be updated via ajax process if change is canceled, previous pickup location will be set for pulldown Created attachment 53046 [details] [review] Bug 8030 - Change pickup location of a hold from patron record To test: 1 - Place some holds for a patron 2 - Load the patron into checkout module 3 - View thier holds tab, should have a dropdwon for location 4 - Alter the location 5 - You should recieve a confirmation box 6 - Confirm that pressing cancel does not update holds 7 - Confirm that pressing Yes does update the hold 8 - Confirm that waiting holds are not updateable needs to adjust for in transit holds Created attachment 53047 [details] [review] Bug 8030 - Change pickup location of a hold from patron record To test: 1 - Place some holds for a patron 2 - Load the patron into checkout module 3 - View thier holds tab, should have a dropdwon for location 4 - Alter the location 5 - You should recieve a confirmation box 6 - Confirm that pressing cancel does not update holds 7 - Confirm that pressing Yes does update the hold 8 - Confirm that waiting holds are not updateable Would it be possible to return the branch <select> to its original choice if you choose "cancel" after changing it? Created attachment 53508 [details] [review] [SIGNED-OFF] Bug 8030 - Change pickup location of a hold from patron record To test: 1 - Place some holds for a patron 2 - Load the patron into checkout module 3 - View thier holds tab, should have a dropdwon for location 4 - Alter the location 5 - You should recieve a confirmation box 6 - Confirm that pressing cancel does not update holds 7 - Confirm that pressing Yes does update the hold 8 - Confirm that waiting holds are not updateable Signed-off-by: Jason M. Burds <JBurds@dubuque.lib.ia.us> (In reply to Owen Leonard from comment #6) > Would it be possible to return the branch <select> to its original choice if > you choose "cancel" after changing it? I think that's a good idea. It would also be nice to have a spinner next to the pulldown while it's being updated. Right now I'm not seeing any real visual feedback that the update is in process or has completed. Take a look at the Animated Icons section here: http://fontawesome.io/examples/ Nick, can you please take a look at the questions and comments? Thx! Created attachment 54659 [details] [review] Bug 8030 (QA Followup) - Use REST api and provide feedback Use REST API If cancelled return to previous selection If fail return to previous selection Use fa spinning icon while waiting Disable select while waiting (In reply to Katrin Fischer from comment #10) > Nick, can you please take a look at the questions and comments? Thx! All set I did an admittedly rough job of inserting the icon, some feedback from Owen on placement and preferred icon would be apreciated Hi Nick, some issues here: 1) You forgot to remove the update_location file form svc that is no longer used. 2) when changing the pickup location I get an alert "You want to change the pickup location?" - I am not sure this kind of message is necessary, we usually only seem to ask for confirmation when something is deleted. 3) After confirming the message, I get an error alert: There was an error:error Method Not Allowed Ah, one more small thing, could we use "updated" instead of "set" to indicate a change? "set" is quite hard to translate correctly. (In reply to Nick Clemens from comment #11) > Use fa spinning icon while waiting Do you have a plan to replace other spinners in the interface with this version? We need to keep things consistent. Created attachment 54712 [details] [review] Bug 8030 - (QA followup) Remove svc file no longer user Use animated gif for waiting as elsewhere Remove confirmation (In reply to Katrin Fischer from comment #13) > 3) After confirming the message, I get an error alert: There was an > error:error Method Not Allowed I don't see this one, do you have the REST API running? Hm, I haven't installed the RESTful API or activated it. I didn't suspect it to be a mandatory thing at this point in time, am I mistaken? Owen had the same error message testing this. (In reply to Katrin Fischer from comment #18) > Hm, I haven't installed the RESTful API or activated it. I didn't suspect it > to be a mandatory thing at this point in time, am I mistaken? > Owen had the same error message testing this. As of bug 17030 the REST API should be activated by default for new installs/upgrades and this feature is based on that assumption. If you add Mirko's nightly builds to your apt sources and upgrade then all should be running: https://apt.abunchofthings.net/koha-nightly/ you can test by accessing the staff url of your site at http://localhost:8081/api/v1/holds Updating hostname/port as necessary If all is working you will get a JSON blob of the holds in your system I am adding this to the agenda of the next dev meeting - I think if we make the API mandatory, we need to take other steps too (amending installation instructions for exapmle) and we should be aware of it. We've concluded to wait for this until bug 14868 is sorted out and not to backport REST API patches for now to the stable releases until we have worked out the structure of things a bit more. Marking 'BLOCKED' for now - please swich back once dependencies have been cleared! Created attachment 55200 [details] [review] [PASSED QA] Bug 8030 - Change pickup location of a hold from patron record To test: 1 - Place some holds for a patron 2 - Load the patron into checkout module 3 - View thier holds tab, should have a dropdwon for location 4 - Alter the location 5 - You should recieve a confirmation box 6 - Confirm that pressing cancel does not update holds 7 - Confirm that pressing Yes does update the hold 8 - Confirm that waiting holds are not updateable Signed-off-by: Jason M. Burds <JBurds@dubuque.lib.ia.us> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 55201 [details] [review] [PASSED QA] Bug 8030 (QA Followup) - Use REST api and provide feedback Use REST API If cancelled return to previous selection If fail return to previous selection Use fa spinning icon while waiting Disable select while waiting Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 55202 [details] [review] [PASSED QA] Bug 8030 - (QA followup) Remove svc file no longer user Use animated gif for waiting as elsewhere Remove confirmation Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> This patch uses GetBranchesLoop which has been removed. Please provide followup to use Koha::Libraries! Created attachment 55448 [details] [review] Bug 8030 - (QA Folllowup) Use Koha::Libraries Pushed to master for 16.11, thanks Nick! This should be first Koha report using the REST API at the intranet side. |