Summary: | Sort lists by call number | ||
---|---|---|---|
Product: | Koha | Reporter: | Melia Meggs <melia> |
Component: | Lists | Assignee: | Marcel de Rooy <m.de.rooy> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jcamins, jonathan.druart, joseanjos, m.de.rooy |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 9167 | ||
Attachments: |
Patch for sorting lists on callnumber
[Signed off] Bug 8032: Sort lists by call number squares between some words in OPAC Bug 9167: Standardize the sort field copyrightdate for lists |
Description
Melia Meggs
2012-05-01 00:53:01 UTC
Hi. It would be very helpfull if we could sort by "Date added". Another great feature it would be the "Export to CSV" option to the Lists. Thanks (In reply to comment #1) > Another great feature it would be the "Export to CSV" option to the Lists. I will use this report for a patch that sorts lists by call number (as in the title). Could you save your additional request on a new separate report? Thanks. Created attachment 13308 [details] [review] Patch for sorting lists on callnumber Precaution: Joining the items table makes that the table is sorted on the item call number of the first item (in case there are more items). Please include following values of OPACXSLTResultsDisplay ("default" and clearing the field) when testing display of lists in OPAC. Also check display in staff client. Here is what I did to test. Staff client: 1. I edited an existing public list to sort it by call number. I can now see a call number column when I look at the list, which appears to be sorted correctly. 2. I created a new public list sorted by call number. I added 8 items to it from search results, and they appeared on the list correctly sorted by call number. 3. I edited an existing private list to sort it by call number. I can now see a call number column when I look at the list, which appears to be sorted correctly. 4. I created a new private list sorted by call number. I added 12 items to it from search results, and they appeared on the list correctly sorted by call number. OPAC (with OPACXSLTResultsDisplay set to "default"): 1. I viewed a public list that is sorted by call number, and it is correctly sorted. I am not able to see the call number of one item that is Checked Out, but it is sorted in the correct place on the list, so everything looks ok. I also viewed a public list that is sorted by title, and it still looks correct. 2. I created a new private list sorted by call number. I added 4 items to it from search results, and they appeared on the list correctly sorted by call number. I then resorted by title, and everything looks good. The only question is that when I go to Lists in the OPAC, I see four columns: List name, Contents, Type, but the fourth column is empty and has no heading. Is the fourth column (furthest to the right) supposed to tell me how the list is sorted? Right now, I have no indication that a particular list is sorted by call number or title unless I try to edit the list. But this blank fourth column looks like it's that way on master as well, so I don't think this patch made any change to that... OPAC (with OPACXSLTResultsDisplay left empty): 1. I viewed a public list, and it is sorted correctly by call number. 2. I viewed a private list, and it is sorted correctly by call number. (Now I can also see the call number of that one item that is Checked Out.) One thing I noticed here is that there are squares that appear between some words when you go to edit a list. I have attached a screenshot. (See Lists -square- Dreams -square- Editing). Not sure if this might be browser related. I am using Chrome if that matters. Overall, I think this patch works beautifully, so I am signing off! Created attachment 13317 [details] [review] [Signed off] Bug 8032: Sort lists by call number Precaution: Joining the items table makes that the table is sorted on the item call number of the first item (in case there are more items). Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> Created attachment 13318 [details]
squares between some words in OPAC
(In reply to comment #7) > Created attachment 13318 [details] > squares between some words in OPAC You found another problem! The caret.gif seems to be moved in master now. It is found now in ccsr subdir. Try: http://yourserver/opac-tmpl/ccsr/images/caret.gif So the template contains a wrong path. The alternative should be: > (>) Template contains: <img src="[% themelang %]/../images/caret.gif" width="16" height="16" alt=">" border="0" /> Thx for signoff! (In reply to comment #8) > (In reply to comment #7) > > Created attachment 13318 [details] > > squares between some words in OPAC > > You found another problem! The caret.gif seems to be moved in master now. It > is found now in ccsr subdir. There is a follow up on bug 7500 for this. QA Comment: This patch adds a new sort for lists. Add/edit a list and set the sort value to callnumber. The results (opac and intranet) are sorted by callnumber. The patch works as expected. The patch uses an existed esoteric way to pass the sort parameter to the templates (sort_$sort => 1 or author_sort => 1 if $sort eq 'author'), it would be great to standardize this stuff. It is not the goal of this patch. Marked as Passed QA. Created attachment 13775 [details] [review] Bug 9167: Standardize the sort field copyrightdate for lists How to reproduce the issue: Create a list at the OPAC and select the sort field 'year'. Go to the list management page at the intranet: the sort field "copyrightdate" is not selected by default. How to test this patch: Check the issue is not still present with this patch. Create several lists at the OPAC with different sort field. Check results are consistent on both interfaces. Check the selected sort field is selected on the edit page. Check there is no regression. What this patch does: - change the way to send the selected sort field to the templates - remove the select tests on the new list page (useless) - the copyrightdate sortfield is named "copyrightdate" everywhere - update your database : set virtualshelves.sortfield = 'copyrightdate' if virtualshelves.sortfield = 'year' (In reply to comment #11) You are in the wrong report? (In reply to comment #12) > (In reply to comment #11) > You are in the wrong report? Oops, yes This patch has been pushed to master. |