| Summary: | today's checkouts are in Previous checkouts in circulation.pl | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Stéphane Delaune <stephane.delaune> |
| Component: | Circulation | Assignee: | Kyle M Hall <kyle.m.hall> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | normal | ||
| Priority: | P3 | CC: | chris, dcook, gmcharlt, jonathan.druart, m.de.rooy, nengard, paul.poulain, sophie.meynieux |
| Version: | 3.8 | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
proposed patch
[SIGNED-OFF] Bug 8043: today's checkouts are in Previous checkouts in circulation.pl Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl [SIGNED-OFF] Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl |
||
|
Description
Stéphane Delaune
2012-05-04 10:10:50 UTC
Created attachment 9411 [details] [review] proposed patch Created attachment 9455 [details] [review] [SIGNED-OFF] Bug 8043: today's checkouts are in Previous checkouts in circulation.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> It looks to me like this was signed off. Marking the bug as such. QA comments:
I think it is better to compare
C4::Dates->new($it->{issuedate}, 'iso')->output('iso')
and
$todaysdate ( = C4::Dates->new->output('iso'))
rather than an obscured substr
Created attachment 9891 [details] [review] Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl Hmm I think the plan is to slowly kill C4::Dates, because it doesnt understand times at all. I am not sure on that, so will check but I think that was the plan *** Bug 7925 has been marked as a duplicate of this bug. *** Just a note from the other bug report: On the checkout summary it used to split today's checkouts and previous checkouts: http://manual.koha-community.org/3.6/en/images/circ/checkoutsummary.png A simple solution could be to only get date in sql request : SELECT DATE(issuedate), DATE(date_due), ... But if all thoses columns are now Datetime, I suppose that's because we need the time somewhere (I didn't see where). If C4::Dates should be abandonned, we could use DateTime module and truncate date variables to day before comparison where we don't need time. I think some kind of global best practice should be written to handle date and time consistantly. (In reply to comment #9) > A simple solution could be to only get date in sql request : > SELECT DATE(issuedate), DATE(date_due), ... > But if all thoses columns are now Datetime, I suppose that's because we need > the time somewhere (I didn't see where). > In circulation now, you can specify hourly loans, so times are used for calculating overdues etc. > If C4::Dates should be abandonned, we could use DateTime module and truncate > date variables to day before comparison where we don't need time. > > I think some kind of global best practice should be written to handle date > and time consistantly. Definitely Created attachment 10273 [details] [review] Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl Created attachment 10277 [details] [review] [SIGNED-OFF] Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> The one problem here is related to bug 7444 and that's that the time has been removed. The timestamp was there because of hourly loans and needs to be there. Switching this to "Signed off", because of Nicole's comment and attached patch. QA Comment: While waiting for more spectacular improvements on dates/datetimes in Koha, this simple fix works: e.g. 2012-06-20 13:00 gt 2012-06-20 in order to get today's issues. Passed QA Pushed to 3.8.x, will be in 3.8.3. |
