Summary: | debian/build-git-snapshot should warn user if it fails | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Packaging | Assignee: | Robin Sheat <robin> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8050: Die if package building fails
Bug 8050: Die if package building fails [PASSED QA] Bug 8050: Die if package building fails |
Description
Jared Camins-Esakov
2012-05-05 12:55:29 UTC
Created attachment 37414 [details] [review] Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. Robin, do you think this patch could be useful for you? I haven't had a look at the detail, but based on the subject I think it's a good thing. I'll look closer soon I hope. Created attachment 37425 [details] [review] Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Made a minor change to print the command, add a newline. Jonathan, if you can give my changes a quick review then that'll be enough for me to consider it passed QA too. Created attachment 37453 [details] [review] [PASSED QA] Bug 8050: Die if package building fails The debian/build-git-snapshot script should not return success if an error occurred. Note that sys_command_output won't raise an error if something fails. Signed-off-by: Robin Sheat <robin@catalyst.net.nz> Made a minor change to print the command, add a newline. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> (In reply to Robin Sheat from comment #5) > Jonathan, if you can give my changes a quick review then that'll be enough > for me to consider it passed QA too. Good for me :) Patch pushed to master. Thanks Jonathan! Pushed to 3.18.x will be in 3.18.6 |