Description
D Ruth Holloway
2012-05-09 08:34:05 UTC
Created attachment 9470 [details] [review] Proposed patch I have noticed a few issues with this patch. The layout is wrong for the opac-privacy.pl page, as well as in the language chooser at the bottom: http://screencast.com/t/OQumB19gm I don't like the layout for the opac-messaging.pl, though if native speakers find it acceptable, I am prepared to sign off on it as is (notice the table on the right and the heading on the left): http://screencast.com/t/8Yg94tzAWy There's a similar table layout problem on the suggestions page. On the details page there are a two problems that jump out. 1) The items table is right-justified but the tabs are left-justified. 2) The search pager buttons are backwards. Next is on the right, and previous is on the left, but the arrows are pointing left and right, respectively: http://screencast.com/t/g0G4Ly9l On the advanced search page, the alignment for the search boxes at the top is off: http://www.screencast.com/t/qpGlVCukVpcx This definitely represents a huge improvement, though. Well done! Created attachment 9579 [details] [review] Proposed patch (Staff) This is a first-draft. I expect to find lots of tweaking that needs to be done. Hi Ruth Unfortunately the first patch no longer applies Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css Failed to merge in the changes. Patch failed at 0001 Bug 8061: RTL CSS overrides (OPAC) The second one conflicts too Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc Failed to merge in the changes. I fell like there is some problems facing us to apply rtl direction by default when using on of the rtl languages when I'm trying to set the css files i found that there is some styles cannot be changed from css files only so this is a problem for example : /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/includes/opac-bottom.inc you can see : [% IF ( languages_loop && opaclanguagesdisplay ) %] [% UNLESS ( one_language_enabled ) %] <div id="changelanguage" class="ft"> <div class="lang" style="float:left;padding: 0.1em 0;"><strong>Languages: </strong></div> Floats and this will make the general css files not effect on this file I fix this by hand but I think this must be not here and all the styles must be just in the css files to make it easier in changing the direction to rtl i don't have experience in patching but I hope if some one can guide me how to test your patch I have rtl css files make koha about 80% good in rtl but need some debugging I will attach it here . Created attachment 13087 [details]
RTL css files 80% good
I think this files is good to start with and we can enhance them with time I wish you try them
thanks
karam .
I wish this will be solved in the next koha release 3.12 . Hi Karam, the patches attached here currently no longer apply. We need someone to take a look at them and rebase them on current master. Maybe it coudl be done in smaller steps/patches. Created attachment 17178 [details] [review] Right to left for staff Client Hi all, I think this patch is good for th rtl langs. and based on what D.Ruth send before , I added some edits as a right to left reader. Tested on Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Regards . Hi Karam, thx for working on this. :) Just a few short notes to move this in the right direction (into Koha): - Is your new patch for master or 3.8? - Is it based on Ruth's patch? In this case it would be better if you could provide a follow up with your changes, so that you both can get proper credit for the work that has gone into this. If you need help with git, I am sure we can work something out. If we could get a patch ready for 3.12 in the next few weeks, that would be quite nice! Karam told me that his patch is based on master - so this is good. Not sure if we should just handle it as a rebase and Karam's work as a sign-off? Created attachment 17206 [details] [review] (staff) D.Ruth Patch to fit master I do the changes manually and create this patch that includes the edits from D. Ruth . Karam . Created attachment 17207 [details] [review] (Staff) Enhancement to D.Ruth Patch This second patch includes the modifications that I made . Hi Katrin I hop this will solve the problem ^_^ . Best regards Karam. Karam++ :) Created attachment 17215 [details] [review] (Opac-Prog) D.Ruth patch to fit master I do the changes manualy and create this patch from D.Ruth work . on Opac prog . it is very useful I do my changes in the next patch ... Created attachment 17216 [details] [review] Follw up (Opac-Prog) enhancment on D.Ruth work .. This will make the opac very acceptable by the rtl users :) Created attachment 17231 [details] [review] [SIGNED-OFF] Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. Created attachment 17232 [details] [review] Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before , I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (b Created attachment 17233 [details] [review] [SIGNED-OFF] Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. Created attachment 17234 [details] [review] Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Created attachment 17235 [details] [review] [SIGNED-OFF] Bug 8061: RTL CSS overrides (OPAC) This patch repairs a few things in templates and CSS to allow for the injection of right-to-left CSS, also in this patch. It should apply to 3.8 and master. To test, install and enable a right-to-left language for the OPAC, currently Hebrew or Arabic. The Arabic OPAC translations for 3.6 are mostly-complete, so they are a good test case. It's helpful to have a reader of the language handy, but the layout should be easy enough to figure out, even for non-readers. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch adding back author and adding sign off. Created attachment 17236 [details] [review] Bug 8061: Follow Up (Opac-Prog) - enhancement to D Ruth's patch In this Patch I added some changes to the rtl.css file I made some changes in the file opac-bottom.inc and add css classes to the lang list and I define the class value in the opac.css I add If statment to the opac-detail.tt to chose the rtl.css when rtl lang. http://bugs.koha-community.org/show_bug.cgi?id=8061 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Reformatted commit message and added bug number. These patches are now waiting for sign offs on the follow-ups Karam did. Created attachment 17237 [details] [review] Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17238 [details] [review] Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Created attachment 17239 [details] [review] Bug 8061: RTL CSS overrides (OPAC) This patch repairs a few things in templates and CSS to allow for the injection of right-to-left CSS, also in this patch. It should apply to 3.8 and master. To test, install and enable a right-to-left language for the OPAC, currently Hebrew or Arabic. The Arabic OPAC translations for 3.6 are mostly-complete, so they are a good test case. It's helpful to have a reader of the language handy, but the layout should be easy enough to figure out, even for non-readers. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch adding back author and adding sign off. Created attachment 17240 [details] [review] Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17241 [details] [review] Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17242 [details] [review] Bug 8061: RTL CSS overrides (OPAC) This patch repairs a few things in templates and CSS to allow for the injection of right-to-left CSS, also in this patch. It should apply to 3.8 and master. To test, install and enable a right-to-left language for the OPAC, currently Hebrew or Arabic. The Arabic OPAC translations for 3.6 are mostly-complete, so they are a good test case. It's helpful to have a reader of the language handy, but the layout should be easy enough to figure out, even for non-readers. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch adding back author and adding sign off. Created attachment 17243 [details] [review] Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17244 [details] [review] Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17245 [details] [review] Bug 8061: Follow Up (Opac-Prog) - enhancement to D Ruth's patch In this Patch I added some changes to the rtl.css file I made some changes in the file opac-bottom.inc and add css classes to the lang list and I define the class value in the opac.css I add If statment to the opac-detail.tt to chose the rtl.css when rtl lang. http://bugs.koha-community.org/show_bug.cgi?id=8061 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Reformatted commit message and added bug number. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Created attachment 17246 [details] [review] [PASSED QA] Bug 8061: RTL CSS overrides (staff client) This patch tweaks a few templates, and enables right-to-left flipping via CSS in the staff client. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch, putting back author and adding sign off. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with Arabic po files from 3.8. All tests and QA script pass. Created attachment 17247 [details] [review] [PASSED QA] Bug 8061: RTL CSS overrides (OPAC) This patch repairs a few things in templates and CSS to allow for the injection of right-to-left CSS, also in this patch. It should apply to 3.8 and master. To test, install and enable a right-to-left language for the OPAC, currently Hebrew or Arabic. The Arabic OPAC translations for 3.6 are mostly-complete, so they are a good test case. It's helpful to have a reader of the language handy, but the layout should be easy enough to figure out, even for non-readers. Signed-off-by: Karam Qubsi <karamqubsi@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended patch adding back author and adding sign off. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 17248 [details] [review] [PASSED QA] Bug 8061: Follow up - RTL CSS overrides (staff client) I think this patch is good for th rtl langs. and based on what D.Ruth send before, I added some edits as a right to left reader. Tested on master with Arabic I used the updated po files for v. 3.8 (because the 3.12 ) need some revision ... Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Created attachment 17249 [details] [review] [PASSED QA] Bug 8061: Follow Up (Opac-Prog) - enhancement to D Ruth's patch In this Patch I added some changes to the rtl.css file I made some changes in the file opac-bottom.inc and add css classes to the lang list and I define the class value in the opac.css I add If statment to the opac-detail.tt to chose the rtl.css when rtl lang. http://bugs.koha-community.org/show_bug.cgi?id=8061 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Reformatted commit message and added bug number. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with po files for Arabic from 3.8. All tests and QA script pass. This patch has been pushed to master and 3.12.x. Created attachment 17286 [details] [review] OPAC-CCSR-Right-to-left-css Hi :) This patch will add css file for the Opac cssr link this css file in the doc-head-close.inc and add new image : arrow-left-grey-11x6.png for the opposite direction of the right existing one . The test plan is the same for the oldest patches for opac prog and intranet ... I think now all Koha interfaces support rtl languages thanks for you All . Karam. I reported a new bug for the ccsr so the : OPAC-CCSR-Right-to-left-css (11.00 KB, patch) is obsoleted the new bug . http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 |