Summary: | my summary showing contents of incorrect tab | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, gmcharlt, koha.sekjal, mglavica, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 5184 | ||
Bug Blocks: | |||
Attachments: |
checked out showing fines
fines on check out tab in staff Bug 8078 - my summary showing contents of incorrect tab checkouts above tabs Bug 8078 [REVISED] my summary showing contents of incorrect tab [SIGNED-OFF] Bug 8078 [REVISED] my summary showing contents of incorrect tab |
Created attachment 9526 [details]
fines on check out tab in staff
Apparently the same is happening in the staff client: cgi-bin/koha/members/moremember.pl?borrowernumber=51
This is almost certainly related to the jQuery upgrade. Created attachment 9527 [details] [review] Bug 8078 - my summary showing contents of incorrect tab This patch moves the holdings tab content to the correct position sequentially with regard to the order of the tabs themselves. My guess is that the jQuery upgrade has something to do with this change but I'm not sure why (probably something in our aging tabs plugin which works differently with the new jQuery version). Making the sequence of the tab contents match the sequence of the tabs seems to fix the problem. Created attachment 9528 [details]
checkouts above tabs
Works in the OPAC, but in the staff client it does something strange.
Created attachment 9627 [details] [review] Bug 8078 [REVISED] my summary showing contents of incorrect tab This patch moves the holdings tab content to the correct position sequentially with regard to the order of the tabs themselves. My guess is that the jQuery upgrade has something to do with this change but I'm not sure why (probably something in our aging tabs plugin which works differently with the new jQuery version). Making the sequence of the tab contents match the sequence of the tabs seems to fix the problem. Revised to correct the error in placement of the tags markup in the staff client. Created attachment 9651 [details] [review] [SIGNED-OFF] Bug 8078 [REVISED] my summary showing contents of incorrect tab This patch moves the holdings tab content to the correct position sequentially with regard to the order of the tabs themselves. My guess is that the jQuery upgrade has something to do with this change but I'm not sure why (probably something in our aging tabs plugin which works differently with the new jQuery version). Making the sequence of the tab contents match the sequence of the tabs seems to fix the problem. Revised to correct the error in placement of the tags markup in the staff client. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Template only patch moving content around and fixing whitespace. Wraps id attribute in quotes for valid XHTML. Marking Passed QA. This patch should not be backported to 3.8 unless the jquery upgrade is also on 3.8 |
Created attachment 9523 [details] checked out showing fines See attached. When I log in to the OPAC instead of showing my my checkouts it shows my fines, but on the my checkouts tab. I then have to click on the fines tab and the on the checkouts tab to see the checkouts.