Summary: | Remove unused images from the OPAC | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, kyle, mtj, paul.poulain |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 9278 | ||
Bug Blocks: | |||
Attachments: |
Bug 8108 - Remove unused images from the OPAC
Bug 8108 - Remove unused images from the OPAC Bug 8108 [Follow-up] Remove unused images from the OPAC Bug 8108 [Follow-up, revised] Remove unused images from the OPAC Bug 8108 [Follow-up, revised] Remove unused OPAC images Bug 8108 [Follow-up, revised] Remove unused OPAC images Bug 8108 [Follow-up, revised] Remove unused OPAC images |
Description
Owen Leonard
2012-05-16 13:27:55 UTC
Created attachment 9619 [details] [review] Bug 8108 - Remove unused images from the OPAC Removing image files which are no longer used. Some have been replaced by a sprite, some by CSS gradients, and some are simply left behind from previous designs. Created attachment 9654 [details] [review] Bug 8108 - Remove unused images from the OPAC Removing image files which are no longer used. Some have been replaced by a sprite, some by CSS gradients, and some are simply left behind from previous designs. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Could one of you (chris / owen) let us know how you've got the list of unused images ? QA comments: remove-file only patch. passed QA (will push once I can be sure that the images are safely removed) (In reply to comment #3) > Could one of you (chris / owen) let us know how you've got the list of > unused images ? I searched for references to each individual file in CSS and TT files. I searched remaining references to some (not all) files removed. Could not find any problem. Patch pushed Patch could be backported to 3.8 but can also wait for 3.10 to avoid any regression in case we missed something I'm moving this back to ASSIGNED because I see a couple images which are still present but I think unused. I think the star ratings images can now be safely removed as well now that they're replaced by a sprite. Created attachment 13600 [details] [review] Bug 8108 [Follow-up] Remove unused images from the OPAC This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Created attachment 13944 [details] [review] Bug 8108 [Follow-up, revised] Remove unused images from the OPAC This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revision: Rebased on current master It looks like some of these images are still referenced in some css files. I imagine that's a problem. $ git grep "addtobasket.gif" koha-tmpl/opac-tmpl/ccsr/en/css/sanop.css: background-image: url(../images/addtobasket.gif); koha-tmpl/opac-tmpl/prog/en/css/sanop.css: background-image: url(../images/addtobasket.gif); git grep "cart-small.gif" koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css: background: transparent url("../../img/cart-small.gif") 0 3px no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/sanop.css: background-image : url(../images/cart-small.gif); koha-tmpl/opac-tmpl/prog/en/css/sanop.css: background-image : url(../images/cart-small.gif); I have submitted a patch for Bug 9278 which removes sanop.css. This should eliminate the references noted in Comment 9. I found some references to these files: koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings-empty.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background: url(../../images/star-ratings.gif) top left no-repeat; koha-tmpl/opac-tmpl/prog/en/css/opac.css: background: url(../../images/star-ratings.gif) top left no-repeat; koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background-image: url(../../images/tag-small-disabled.png); koha-tmpl/opac-tmpl/ccsr/en/css/opac.css: background-image: url(../../images/tag-small.png); Created attachment 14080 [details] [review] Bug 8108 [Follow-up, revised] Remove unused OPAC images This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revisions: - Rebased on current master - Ported some changes to CCSR theme - Removed unused CSS which referred to deleted images Created attachment 14081 [details] [review] Bug 8108 [Follow-up, revised] Remove unused OPAC images This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revisions: - Rebased on current master - Ported some changes to CCSR theme - Removed unused CSS which referred to deleted images Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 14932 [details] [review] Bug 8108 [Follow-up, revised] Remove unused OPAC images This patch cleans up some loose ends: - Star ratings images are now in one sprite. Removing separate star ratings images. - Amazon ratings have been removed. Related image files are removed by this patch. - The tag images associated with tag links on the search results page were not incorporated into the main sprite. Now they are. Added: The Photoshop file from which the main sprite was generated, in case that is helpful to others. Each layer is named, and comments have been added to the CSS referencing the layer names. The file is GIMP-compatible. Revisions: - Rebased on current master - Ported some changes to CCSR theme - Removed unused CSS which referred to deleted images Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Mason James <mtj@kohaaloha.com> (In reply to comment #14) > Created attachment 14932 [details] [review] > Bug 8108 [Follow-up, revised] Remove unused OPAC images > > Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> > Signed-off-by: Mason James <mtj@kohaaloha.com> testing 1 commit(s) (applied to f8686e9 'Bug 9116: Remove some useless tmp var') passing QA - awesome patch Owen :) This patch has been pushed to master. Pushed to 3.10.x will be in 3.10.3 |