Bug 8124

Summary: Hide option to download results of items with no checkouts report
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: normal    
Priority: P3 CC: chris, jonathan.druart, paul.poulain
Version: 3.8   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 8124 - Hide option to download results of items with no checkouts report
Bug 8124 - Hide option to download results of items with no checkouts report

Description Owen Leonard 2012-05-18 14:51:09 UTC
In the template of the "Items with no checkouts" report:

<li><label for="outputfile">To a file: </label><input type="radio" name="output" value="file" id="outputfile" disabled="disabled" /><!-- FIXME: Not implemented -->

That FIXME has been there forever. The option should be hidden until someone actually fixes it.
Comment 1 Owen Leonard 2012-05-18 14:54:50 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2012-05-19 09:28:52 UTC
Created attachment 9653 [details] [review]
Bug 8124 - Hide option to download results of items with no checkouts report

We should not show disabled controls for features which don't work.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 3 Jonathan Druart 2012-05-22 08:59:02 UTC
QA Comments:
Ergonomic changes.
Hide a not implemented feature.
Passed QA
Comment 4 Chris Cormack 2012-05-28 09:34:59 UTC
Pushed to 3.8.x, will be in 3.8.2