Summary: | 775 tag in the MARC record causes display issue | ||
---|---|---|---|
Product: | Koha | Reporter: | Joy Nelson <1joynelson> |
Component: | OPAC | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P1 - high | CC: | chris, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Error in Display when 775 is used
Corrected OPAC display when 775 is removed Bug 8144 - 775 tag in the MARC record causes display issue Bug 8144 - 775 tag in the MARC record causes display issue |
Created attachment 9744 [details]
Corrected OPAC display when 775 is removed
Same problem in the staff client. It's a markup error in the XSLT template. It's clear how the broken markup is causing the problem: <span class="results_summary other_editions"> <span class="label">Other Editions: </span> <a href="/cgi-bin/koha/opac-search.pl?q=ti,phr:"/> </span> The <a> is not closed. But I can't puzzle out why the closing </a> in the .xsl file isn't doing its job. I also can't see why 775$a isn't being output, whether or not the markup is valid. Created attachment 9761 [details] [review] Bug 8144 - 775 tag in the MARC record causes display issue Fixing XSL template in the OPAC and staff client following recommendations by Jared. Created attachment 9786 [details] [review] Bug 8144 - 775 tag in the MARC record causes display issue Fixing XSL template in the OPAC and staff client following recommendations by Jared. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Fixes the markup and correctly displays 775 notes. QA comment: XSLT related only, passed QA Patch pushed I haven't a MARC21 setup at hand, so haven't checked the patch. Seems tiny enough & expecienced author/signoffer, so I trust them. BUT please test ! Tested with marc21, works well, pushed to 3.8.x, will be in 3.8.2 |
Created attachment 9743 [details] Error in Display when 775 is used MARC record with a 775 tag launches a 'second search' on ti, phr: in the results display. See attached screenshot. One shows OPAC when 775 is on MARC and the other after the 775 tag is removed.