Summary: | Bulk serial receive | ||
---|---|---|---|
Product: | Koha | Reporter: | shinoy m <shinoy.m> |
Component: | Serials | Assignee: | Colin Campbell <colin.campbell> |
Status: | RESOLVED DUPLICATE | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Bulk serial receive |
Description
shinoy m
2012-05-25 10:04:27 UTC
Created attachment 9809 [details] [review] Bulk serial receive Add an option "Bulk receive" in serials home page for receiving the serials in bulk. I like the idea, however +#if it is bulk receive +if($op eq 'all') +{ +my $sth = $dbh->prepare('select subscriptionid from subscription'); +$sth->execute; +my $row; +while ($row = $sth->fetchrow_array()) { +push (@subscriptionids,$row); +} +}else { +@subscriptionids = $query->param('subscriptionid'); +} in serials-edit.pl has a few problems. 1/ We shouldn't have sql in .pl files 2/ The indentation fails the coding guidelines 3/ This will get all expired subscriptions, ie, it just gets all, that may be thousands for a big library I haven't tested much further. What this patch does, also that is not advertised is it changes the layout of the serials receive page also. |