Summary: | Plugin for linking records in MARC21 | ||
---|---|---|---|
Product: | Koha | Reporter: | Zeno Tajoli <ztajoli> |
Component: | Cataloging | Assignee: | Zeno Tajoli <ztajoli> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, mirko, paul.poulain, ztajoli |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
code of the plugin
linking plugin marc21 Bug 8185 Follow-Up: Some more Italian strings changed This is the plugin for linking records in Marc21. Bug 8185 Follow-Up: Some more Italian strings changed Bug 8185 Change some more strings from Italian to English Bug 8185: plugin for linking records in MARC21 Bug 8185: Change some more strings from Italian to English Bug 8185: Change some more strings from Italian to English |
Description
Zeno Tajoli
2012-06-03 17:20:48 UTC
Created attachment 9904 [details] [review] code of the plugin This is the plugin for linking records in Marc21. It works like the unimarc plugin unimarc_field_4XX. It insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title ) $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on 'any' index. Data are inserted only in the working record. To insert data in the connected record, you need to open the other record. - I set up sandbox 8 (http://pro.test8.biblibre.com/) to display 773 9, t, w, x, z in default marc framework - linked the new plugin for subfield 9 - added a second biblio - added data in 001, 020, 022 to second biblio, saved - opened first biblio (sandbox test) - clicked plugin button at 777$9 - searched for "test" - chose biblio2 (marc21 test) All data was added to fields 773 9, t, w, x, z, script is functional. But it is in Italian. Text comes from tt file so it should be translatable strings instead. Correct, there are strings in italian. I update a new version full in english as soon as possible Created attachment 11327 [details] [review] linking plugin marc21 Now the plugin is all in english Created attachment 11510 [details] [review] Bug 8185 Follow-Up: Some more Italian strings changed Functionality is still fine, but I found more Italian strings. Sent a followup patch, somebody else needs to signoff. Created attachment 11529 [details] [review] This is the plugin for linking records in Marc21. It works like the unimarc plugin unimarc_field_4XX. It insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title ) $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on 'any' index. Data are inserted only in the working record. To insert data in the connected record, you need to open the other record. http://bugs.koha-community.org/show_bug.cgi?id=8185 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 11530 [details] [review] Bug 8185 Follow-Up: Some more Italian strings changed I signed off on Zeno's patch. It works as expected. Since it had some Italian inside I provided a tiny followup. Only the followup needs a signoff by verifying that there is no Italian in the plugin. Mirko, I tried to apply the follow-up on top of the original signed off patch, but got the following error: Commit Body is: -------------------------- Bug 8185 Follow-Up: Some more Italian strings changed -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 8185 Follow-Up: Some more Italian strings changed /home/jcamins/kohaclone/.git/rebase-apply/patch:14: tab in indent. <h2>Search for</h2> fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_linking_section.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8185 Follow-Up: Some more Italian strings changed When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Should there be another follow-up in between the two? Jared, thanks for trying. That is odd, seems like I screwed something up when I signed off the first patch. I'll redo the second patch. Created attachment 11559 [details] [review] Bug 8185 Change some more strings from Italian to English I redid the second patch and checked that both patches apply cleanly for me. Created attachment 11587 [details] [review] Bug 8185: plugin for linking records in MARC21 This plugin works like the unimarc plugin unimarc_field_4XX. It insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title ) $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on 'any' index. Data are inserted only in the working record. To insert data in the connected record, you need to open the other record. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Created attachment 11588 [details] [review] Bug 8185: Change some more strings from Italian to English Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Two additional corrections Looks like this is supposed to be signed off, both patches are signed off Created attachment 11596 [details] [review] Bug 8185: Change some more strings from Italian to English Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Two additional corrections Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> (Mit Bezug zu comment 18) > Looks like this is supposed to be signed off, both patches are signed off Jared signed off my corrections, added two more and asked me to sign them off, so he left it "Needs signoff". I signed off now, we're ready for QA. QA comment: * passes perlcritic & valid-templates * plugin written like all other plugins passed QA Patch pushed to master (untested, MARC21 specific & no side effect possible) |