Summary: | Add authorities to export tool | ||
---|---|---|---|
Product: | Koha | Reporter: | Jared Camins-Esakov <jcamins> |
Component: | Tools | Assignee: | Jared Camins-Esakov <jcamins> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 7986, 8203, 8212, 8268 | ||
Attachments: |
Bug 8202: Add authority export to tools/export.pl
[SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl [SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl Bug 8202 follow-up UNIMARC authority support Bug 8202 follow-up UNIMARC authority support |
Description
Jared Camins-Esakov
2012-06-07 12:34:25 UTC
Created attachment 10305 [details] [review] Bug 8202: Add authority export to tools/export.pl Adds a separate tab on tools/export.pl for exporting authority records. To test: 1. Try exporting authority records from the "Export data" tool Created attachment 10311 [details] [review] [SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl Adds a separate tab on tools/export.pl for exporting authority records. To test: 1. Try exporting authority records from the "Export data" tool Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tried different exports and everything worked nicely: - removing fields from export (example: 942) - limiting to one authority type - changing the given file name - exporting as MARC or XML Arf, A patch for Bug 7986 introduces a lot of modifications for the same file tools/export.pl Hi Jonathan, I know it's annoying, but as this patch is already signed off, I don't think the other should block it. This way 2 patches will have to be reworked. QA comments: Hi Jared, Your modifications seem good and they are close to mine (for export.pl). About your patch, I think you can repropose it modifying the indentation of export.tt (ex. + <ol><li> + </li></ol> +[% ELSE %] +<div id="exporttype" class="toptabs"> +<ul> ) I agree with you, I quibble... However, more important, I found a bug in this script while testing. I can't exclude from export some fields, as 500$3 for example. The regexp to split field and subfield is /^(\d*)(\w)?$/; This is not what we want. And, the subfield's deletion: if( $subfield ) { $record->field($field)->delete_subfields($subfield); } only delete in the first field. Sorry, you didn't introduce these bugs. And I can't failed QA only for indentation, I switch back to signed off. (In reply to comment #5) > QA comments: > > Hi Jared, > > Your modifications seem good and they are close to mine (for export.pl). > About your patch, I think you can repropose it modifying the indentation of > export.tt (ex. > + <ol><li> > > + </li></ol> > > +[% ELSE %] > > +<div id="exporttype" class="toptabs"> > +<ul> > ) > > I agree with you, I quibble... I would be happy to submit a follow-up fixing indentation. I was very tempted to reindent export.tt, actually, but section 1.3 in the coding guidelines says don't refactor needlessly, and don't spend time changing someone else's style to yours. :) Created attachment 10607 [details] [review] [SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl Rebased patch Marking as Passed QA (In reply to comment #7) > I would be happy to submit a follow-up fixing indentation. I was very > tempted to reindent export.tt, actually, but section 1.3 in the coding > guidelines says don't refactor needlessly, and don't spend time changing > someone else's style to yours. :) We also have decided to use the default perltidy formatting, so, this rule "wins" against the "don't spend time..." Anyway, there's something wronger than this : you test the MARCflavour, and, if it's UNIMARC you send do ->as_xml('unimarc') When it's an authority, you must do ->as_xml('UNIMARCAUTH') The 100 -coded- field in UNIMARCAUTH has a different size than UNIMARC (biblio) So you get a nasty: Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> 20091001afrey50 ba0 at /usr/share/perl5/MARC/File/XML.pm line 505. (trying to decode a 100 "biblio", but it's an auth, so considered wrong size) yes, that's silly, but UNIMARC is silly ;-) Please signoff the follow-up and i'll push your patch with my (tiny) follow-up Created attachment 10629 [details] [review] Bug 8202 follow-up UNIMARC authority support Created attachment 10630 [details] [review] Bug 8202 follow-up UNIMARC authority support Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> This feature is available in Master. |