Description
Jared Camins-Esakov
2012-06-07 13:05:41 UTC
Created attachment 10545 [details] [review] Bug 8204: Add user friendly authority view to OPAC Up until now, the only authority view in the OPAC was a rather-unfriendly expanded MARC view. This patch adds a user-friendly view similar to the biblio details view. Specific features to be aware of: * Right-to-left text in the MARC21 880 field will show up in the appropriate location with the appropriate alignment and wrapping * There is very little CSS styling. Any suggestions for how to make the display more attractive would be gratefully received. To test: 1) Do a search for an authority in the OPAC. 2) Choose an authority record to view. 3) Observe that the view is more user-friendly and polished. Actually when I click on full heading and get to this page I get cgi-bin/koha/opac-authoritiesdetail.pl?authid=1 Template process failed: file error - /home/christopher/git/koha/koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiesdetail.tt: not found at /home/christopher/git/koha/C4/Templates.pm line 127. I suspect this is another bug. Will try getting to the authority record another way Hmm I have no idea how to get to an authority view in the opac that actually works. Someone will have to tell me how or test this. Chris, (In reply to comment #2) > Actually when I click on full heading and get to this page I get > cgi-bin/koha/opac-authoritiesdetail.pl?authid=1 > > Template process failed: file error - > /home/christopher/git/koha/koha-tmpl/opac-tmpl/prog/en/modules/opac- > authoritiesdetail.tt: not found at > /home/christopher/git/koha/C4/Templates.pm line 127. > > I suspect this is another bug. Will try getting to the authority record > another way Did you update your repo before applying this? As far as I can see, the authorities detail template was changed to opac-auth-detail.tt by f5974e27 (bug 7943 follow-up). That patch is in master. Created attachment 10591 [details] [review] Bug 8204: Add user friendly authority view to OPAC Up until now, the only authority view in the OPAC was a rather-unfriendly expanded MARC view. This patch adds a user-friendly view similar to the biblio details view. Specific features to be aware of: * Right-to-left text in the MARC21 880 field will show up in the appropriate location with the appropriate alignment and wrapping * There is very little CSS styling. Any suggestions for how to make the display more attractive would be gratefully received. To test: 1) Do a search for an authority in the OPAC. 2) Choose an authority record to view. 3) Observe that the view is more user-friendly and polished. Created attachment 10592 [details] [review] Bug 8204: Add user friendly authority view to OPAC Up until now, the only authority view in the OPAC was a rather-unfriendly expanded MARC view. This patch adds a user-friendly view similar to the biblio details view. Specific features to be aware of: * Right-to-left text in the MARC21 880 field will show up in the appropriate location with the appropriate alignment and wrapping * There is very little CSS styling. Any suggestions for how to make the display more attractive would be gratefully received. To test: 1) Do a search for an authority in the OPAC. 2) Choose an authority record to view. 3) Observe that the view is more user-friendly and polished. Revised patch incorporating comments from testers. commit 0923e96cb4a9684db7c777866e9c822522f49a72 Author: Paul Poulain <paul.poulain@biblibre.com> Date: Fri Jun 29 17:17:47 2012 +0200 Revert "Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin" This reverts commit 186cfa5cb00a1c0ee7f0e4512a5f319299bb6412. Yep definitely on master. and koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiessearchresultlist.tt links to <a href="opac-authoritiesdetail.pl?authid=[% resul.authid %]"> And in there i can see the change, template_name => $show_marc ? "opac-auth-MARCdetail.tt" : "opac-auth-detail.tt", But I am still getting Template process failed: file error - /home/christopher/git/koha/koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiesdetail.tt: not found at /home/christopher/git/koha/C4/Templates.pm line 127. But I note ls koha-tmpl/opac-tmpl/prog/en/modules/opac-auth* koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-authorities-home.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tt http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/opac-tmpl/prog/en/modules;h=5330fbfa93f85233cebf2b7ceed1cc495b0ff4b3;hb=0923e96cb4a9684db7c777866e9c822522f49a72 That file does not exist, perhaps thats why its falling back. Am I going blind or does opac-auth-detail.tt really not exist in master? So yes, currently before this patch is applied it is not just ugly, but totally and utterly broken. Due to the fact bug 7943 was pushed. This is doing my head in. Someone else will have to test. (In reply to comment #8) > So yes, currently before this patch is applied it is not just ugly, but > totally and utterly broken. > > Due to the fact bug 7943 was pushed. This seems to be specific to your installation, as it's working for others on unmodified master, and works fine for me even on a completely new installation with unadulterated master. I have absolutely no idea what the problem could be, though. I guess the thing to do is get this signed off and into master as soon as possible, and then it will be a moot point. Hi Jared, I tested this on current master and there are some problems. I got mails with the following errors from my system: Useless use of substr in void context at /home/katrin/kohaclone/C4/AuthoritiesMarc.pm line 1089. Useless use of substr in void context at /home/katrin/kohaclone/C4/AuthoritiesMarc.pm line 1102. The main heading shows as HASH(0x3b1a130). The new detail view displays nicely for me. Some thoughts about this: - The heading "See also:" should only show when there are "see alsos" - I wonder if the "preferred form" should also be bold. I think your patch totally removes the "labelled MARC view". Could it be an option to have tabs for authorities advertising different views? Maybe some time in the future a plain MARC view would also be nice, as would be a download option. >I think your patch totally removes the "labelled MARC view". Could it be an >option to have tabs for authorities advertising different views?
>Maybe some time in the future a plain MARC view would also be nice, as would be >a download option.
was totally wrong about that - tabs are there!
Created attachment 10692 [details] [review] Bug 8204: Add user friendly authority view to OPAC Up until now, the only authority view in the OPAC was a rather-unfriendly expanded MARC view. This patch adds a user-friendly view similar to the biblio details view. Specific features to be aware of: * Right-to-left text in the MARC21 880 field will show up in the appropriate location with the appropriate alignment and wrapping * There is very little CSS styling. Any suggestions for how to make the display more attractive would be gratefully received. To test: 1) Do a search for an authority in the OPAC. 2) Choose an authority record to view. 3) Observe that the view is more user-friendly and polished. Revised the patch to take care of the issues identified by Katrin. Created attachment 10694 [details] [review] Bug 8204: Add user friendly authority view to OPAC Up until now, the only authority view in the OPAC was a rather-unfriendly expanded MARC view. This patch adds a user-friendly view similar to the biblio details view. Specific features to be aware of: * Right-to-left text in the MARC21 880 field will show up in the appropriate location with the appropriate alignment and wrapping * There is very little CSS styling. Any suggestions for how to make the display more attractive would be gratefully received. To test: 1) Do a search for an authority in the OPAC. 2) Choose an authority record to view. 3) Observe that the view is more user-friendly and polished. Created attachment 10700 [details] [review] [SIGNED-OFF] Bug 8204: Add user friendly authority view to OPAC Up until now, the only authority view in the OPAC was a rather-unfriendly expanded MARC view. This patch adds a user-friendly view similar to the biblio details view. Specific features to be aware of: * Right-to-left text in the MARC21 880 field will show up in the appropriate location with the appropriate alignment and wrapping * There is very little CSS styling. Any suggestions for how to make the display more attractive would be gratefully received. To test: 1) Do a search for an authority in the OPAC. 2) Choose an authority record to view. 3) Observe that the view is more user-friendly and polished. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works very nicely now. The old view is still available, but the user is presented with a nicer non-MARC view first. Created attachment 11146 [details]
UNIMARC view wrong
I LOVE the idea of this patch.
However, in UNIMARC, it seems it does not work at all :'(
Created attachment 11148 [details] [review] Bug 8204: fix UNIMARC display UNIMARC display of authorities in the OPAC wasn't working due to changes in the BuildSummary function since the code was originally developed. QA comment: astonishing improvement ! passed QA Just 2 comments: * I see an empty "Note" tab, shouldn't it not be here if it is empty ? * there is no space between preffered form and authtypecode, I think adding one would be nice Another comment: why didn't you choose to have a XSLT display ? That would have been the best option I think. But that can be for another patch ;-) No database changes, fixes what is a bug really. (No one should have to see MARC least of all poor unsuspecting catalogue users) :) Pushed to 3.8.x will be in 3.8.4 This patch introduces a warning : % perl -wc C4/AuthoritiesMarc.pm "my" variable $sth masks earlier declaration in same scope at /home/jonathan/workspace/versions/koha_master/C4/Accounts.pm line 220. Use of qw(...) as parentheses is deprecated at /home/jonathan/workspace/versions/koha_master/C4/Serials.pm line 583. Use of qw(...) as parentheses is deprecated at /home/jonathan/workspace/versions/koha_master/C4/Serials.pm line 596. "my" variable @fields masks earlier declaration in same scope at C4/AuthoritiesMarc.pm line 1017. The last one didn't exist before. Created attachment 11159 [details] [review] Bug 8204 follow-up: quiet warn Jared, Thanks for your reactivity :) This patch removes the warning but I think l.974 can be removed too. Created attachment 11160 [details] [review] Bug 8204 follow-up: quiet warn Also removes unnecessary variable declaration. Thanks to Jonathan Druart for spotting it. Created attachment 11164 [details] [review] Bug 8204 follow-up: quiet warn Also removes unnecessary variable declaration. Thanks to Jonathan Druart for spotting it. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 11173 [details]
template error
When viewing /opac-authoritiesdetail.pl?authid=491 it pushes the opac nav down instead of floating to the right of it - this is on Mac in FF and Chrome.
(In reply to comment #26) > When viewing /opac-authoritiesdetail.pl?authid=491 it pushes the opac nav > down instead of floating to the right of it - this is on Mac in FF and > Chrome. Same for me: FF on *Windows* :) Nice feature/fix BTW! I came across the warning too now. Latest patch removes some unneeded lines. Passed QA follow-up pushed Follow up pushed the 3.8.x will be in 3.8.4 Comment 26 is still an issue in FF on Mac on Master. "Reopening" and up-ping severity, if it happen on FF-windows, it must be fixed ! Created attachment 11841 [details] [review] Bug 8204 follow-up: don't display OpacNav on auth details Based on the way we handle the bib details page, it seems we should not be displaying OpacNav on the authority details pages on the OPAC. This patch removes them. Created attachment 11852 [details] [review] Bug 8204 follow-up: don't display OpacNav on auth details Based on the way we handle the bib details page, it seems we should not be displaying OpacNav on the authority details pages on the OPAC. This patch removes them. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Last patch removes th OpacNav on the opac authority detail page. Marked as Passed QA. Follow-up pushed Pushed to 3.8.x, will be in 3.8.5 |