Summary: | User created lists not sorting properly | ||
---|---|---|---|
Product: | Koha | Reporter: | Chris Hall <chrish> |
Component: | OPAC | Assignee: | Chris Hall <chrish> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | trivial | ||
Priority: | P5 - low | CC: | chris, chrish, paul.poulain, veron |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Fixing year sorting of OPAC lists
[SIGNED-OFF] bug 8323 fixing year sorting of a list |
Description
Chris Hall
2012-06-27 01:37:09 UTC
Created attachment 10530 [details] [review] Fixing year sorting of OPAC lists Patch attached to fix, will pass sort field through the the SQL and will change 'year' to 'copyrightdate'. Created attachment 10537 [details] [review] [SIGNED-OFF] bug 8323 fixing year sorting of a list Signed-off-by: Marc Veron <veron@veron.ch> Works as expected. Caveat: If you edit the list in Opac, change the sort and then klick 'Save', the List always is displayed in title order. This is du to the fact that save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults to 'title'). If you go back to lists, choose the list from List name, the param is correct and the list displays in expected order. It took quite a time to track that down, I first thought that opac-shelves.pl was broken. However, current bug 8323 is not affected, signing off. Marc Opend a bug for wrong sort order just after editing (8324). QA comment: * Having to do $sortfield eq 'year' ? 'copyrightdate' : $sortfield proves that there's something wrong in the parameters. It's not in the scope of this patch to fix this, but if you want to provide a follow-up to have 'copyrightdate' in $sortfield instead of year, you'll be welcomed ! Otherwise, tiny patch, passes QA Pushed to 3.8.x, will be in 3.8.3 |