Summary: | SIP Server does not process renewal transaction correctly | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | SIP2 | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | major | ||
Priority: | P1 - high | CC: | chris, colin.campbell, mtj, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed Patch
Revised Patch Bug 8336 Support Sip Renewal Transaction |
Description
Colin Campbell
2012-06-29 17:36:41 UTC
Created attachment 10567 [details] [review] Proposed Patch Tested by Staffordshire University with help from Talking Tech Created attachment 12035 [details] [review] Revised Patch Cleaned up the code. Handle some cases better - rebased against current master Changed status to bug as without this patch the SIPServer crashes when faced with a RenewAll transaction. Also the current sip server reports to the client that it supports Renew and Renewall transactions but it does not and in ways that cause the client and/or server to fail. Tested by Staffordshire University with Talking Tech telephone renewals Created attachment 12260 [details] [review] Bug 8336 Support Sip Renewal Transaction Renewals were being rejected for incorrect reasons Checking was being done against the wrong object Add more informative messages on failure Correctly set due_date for renewal response Avoid crashing the SIPServer because it handles RenewAll incorrectly Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> $ koha-qa.pl patch looks good, passing QA… testing 1 commit(s) (applied to commit 2a60d49) * 551c673 Bug 8336 Support Sip Renewal Transaction C4/SIP/ILS.pm C4/SIP/ILS/Transaction/Renew.pm C4/SIP/ILS/Transaction/RenewAll.pm C4/SIP/Sip/MsgType.pm * C4/SIP/ILS.pm OK * C4/SIP/ILS/Transaction/Renew.pm OK * C4/SIP/ILS/Transaction/RenewAll.pm OK * C4/SIP/Sip/MsgType.pm OK Patch pushed to master (patch untested by me though) Pushed to 3.8.x, will be in 3.8.5 |