| Summary: | use English not needed in modules not using English | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
| Component: | SIP2 | Assignee: | Colin Campbell <colin.campbell> |
| Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | chris, colin.campbell, jonathan.druart, kyle |
| Version: | 3.12 | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Proposed Patch
Bug 8433 Remove unused 'use English' Bug 8433 Remove unused 'use English' |
||
|
Description
Colin Campbell
2012-07-12 16:10:06 UTC
Created attachment 10802 [details] [review] Proposed Patch code cleanup removing unused module reference Changed from enh -> trivial Created attachment 14242 [details] [review] Bug 8433 Remove unused 'use English' Adding a use English to mosules which dont may waste a few CPU cycles and bytes of storage but doesnt add anything to the sum of human happiness Remove unnecessary use English's Removed already commented out but equally unnrcessary use Exporter in same modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> QA Comments: I did not test this patch. This patch removes the English module in 5 modules (and 3 commented lines). Looks good to me. Marked as Passed QA. Created attachment 14416 [details] [review] Bug 8433 Remove unused 'use English' Adding a use English to mosules which dont may waste a few CPU cycles and bytes of storage but doesnt add anything to the sum of human happiness Remove unnecessary use English's Removed already commented out but equally unnrcessary use Exporter in same modules Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Is there a way to test these changes are safe? Jared, I think the script xt/find-undefined-subroutines.pl could help us here. I launched it after applying this patch and I found no error previously existing. (In reply to comment #6) > Is there a way to test these changes are safe? Compling the scripts with strict and warnings enables should indicated if any references remain to entities defined in English.pm This patch has been pushed to master. |