Summary: | Printing basketgroup does not work on plack | ||
---|---|---|---|
Product: | Koha | Reporter: | Paul Poulain <paul.poulain> |
Component: | Acquisitions | Assignee: | Dobrica Pavlinusic <dpavlin> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P5 - low | CC: | chris, dpavlin, mirko |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8439 - Printing basketgroup does not work on plack
Bug 8439 - plack code cleanup [SIGNED-OFF] Bug 8439 - Printing basketgroup does not work on plack |
Description
Paul Poulain
2012-07-13 12:40:04 UTC
Created attachment 10868 [details] [review] Bug 8439 - Printing basketgroup does not work on plack scope $input CGI object with our for plack Created attachment 11024 [details] [review] Bug 8439 - plack code cleanup - remove all exit(1) and replace them with __END__ which benefits CGI - insert correct =cut markers at end of POD (required for CGI::Compile under plack to correctly parse source code and exeute it) - scope variables with our which are used inside sub for plack Created attachment 11030 [details] [review] [SIGNED-OFF] Bug 8439 - Printing basketgroup does not work on plack scope $input CGI object with our for plack Signed-off-by: Mirko Tietgen <5p4m@gmx.de> The first patch fixes the problem of printing a basket group and is signed off. The second patch seems to be unrelated to this bug, I have not tested it. I mark this as signed off now so the first patch can go to QA. Sorry about confusion, second patch was supposed to end up in Bug 8482 - labels creator fixes for plack QA comment: tiny patch, same as what is made for other patches for Plack Pushed to 3.8.x, will be in 3.8.4 |