Summary: | Dates does not appear in suggestions management | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Acquisitions | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8443 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 8440: Dates does not appear in suggestions management Proposed patch (follow-up) [SIGNED-OFF] Proposed patch (follow-up) |
Description
Fridolin Somers
2012-07-13 13:14:18 UTC
Created attachment 10820 [details] [review] Proposed patch small bug, seems to come from a merge. Created attachment 10906 [details] [review] [SIGNED-OFF] Bug 8440: Dates does not appear in suggestions management Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comments: Works as exepted. Remove duplicate code Marking as Passed QA. It would be great to use KohaDates instead of format_date in suggestion.pl (In reply to comment #3) > It would be great to use KohaDates instead of format_date in suggestion.pl Agreed (and agreed it's out of the scope of this patch A minor inconsistency that is due to this patch but a follow-up is welcomed: Suggested by/on says : BERNARDI, Nicole / 24/05/2011 Managed by/on says: BLOT, Sylvie , 10/06/2011 ("/" as separator for one "," for the other) Pushed to 3.8.x, will be in 3.8.4 Created attachment 11119 [details] [review] Proposed patch (follow-up) Response to comment #4 : I choosed to separate patron and date by a "-" since patron uses already the "," a comment #6 ... I choosed to separate patron and date by a "-" since patron uses already the "," and date the "/" (save ISO format). Comment on attachment 10906 [details] [review] [SIGNED-OFF] Bug 8440: Dates does not appear in suggestions management already pushed Created attachment 11122 [details] [review] [SIGNED-OFF] Proposed patch (follow-up) Simple patch QA Comments: Make strings consistent. Marked as Passed QA Pushed follow up to 3.8.x, will be in 3.8.4 Follow-up pushed to master. Already on stable, setting status accordingly |