| Summary: | Koha/SearchEngine/Solr/Search.pm fails perlcritic test | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Mason James <mtj> |
| Component: | Architecture, internals, and plumbing | Assignee: | Mason James <mtj> |
| Status: | CLOSED FIXED | QA Contact: | Paul Poulain <paul.poulain> |
| Severity: | major | ||
| Priority: | P1 - high | CC: | chris, jonathan.druart, paul.poulain |
| Version: | 3.10 | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test
Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test |
||
|
Description
Mason James
2012-07-18 02:08:11 UTC
Created attachment 10915 [details] [review] Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test modified: Koha/SearchEngine/Solr/Search.pm (In reply to comment #1) > Created attachment 10915 [details] [review] > Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test > > modified: Koha/SearchEngine/Solr/Search.pm - before patch... $ perlcritic Koha/SearchEngine/Solr/Search.pm Variable declared in conditional statement at line 41, column 5. Declare variables outside of the condition. (Severity: 5) - after patch... $ perlcritic Koha/SearchEngine/Solr/Search.pm Koha/SearchEngine/Solr/Search.pm source OK Created attachment 10933 [details] [review] Bug 8463 - Koha/SearchEngine/Solr/Search.pm fails perlcritic test modified: Koha/SearchEngine/Solr/Search.pm Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> QA comment: tiny patch just for perlcritic. Fixes perlcritic stuff, so it's OK Released in 3.10.0 |