Summary: | Strange behavior when modifying the 'timeout' system preference. | ||
---|---|---|---|
Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
Component: | System Administration | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | critical | ||
Priority: | P5 - low | CC: | chris, gmcharlt, mtj, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5998 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed patch
[SIGNED-OFF] Bug 8497: Strange behavior when modifying the timeout system preference |
Description
Kyle M Hall (khall)
2012-07-24 12:44:48 UTC
Created attachment 12629 [details] [review] Proposed patch The use of 1d (=one day) in "timeout" syspref was only checked in normal authentication (Auth.pm checkauth), it was missing in check_api_auth() and check_cookie_auth(). I add a private method in Auth.pm : _timeout_syspref(). Test plan : - Set timeout syspref to 1d - Login in intranet (uses checkauth) - In header, use borrower auto-completion in "check out" (uses check_cookie_auth) - Go to Administration/System preferences, modify a syspref and save (check_api_auth) Created attachment 12645 [details] [review] [SIGNED-OFF] Bug 8497: Strange behavior when modifying the timeout system preference Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested standard login, patron auto-complete, and system preferences. (In reply to comment #2) > Created attachment 12645 [details] [review] > [SIGNED-OFF] Bug 8497: Strange behavior when modifying the timeout system > preference > > Signed-off-by: Owen Leonard <oleonard@myacpl.org> > > Tested standard login, patron auto-complete, and system preferences. passing QA, works as expected $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 0a35b26) * dec46ae Bug 8497: Strange behavior when modifying the timeout system preference C4/Auth.pm * C4/Auth.pm OK Patch pushed to master Pushed to 3.8.x, will be in 3.8.6 |