Bug 8498

This patch adds *all* jQueryUI interactions, widgets, and effects to Koha, whereas I was trying to add them only as needed. I would prefer it if you could use the jQueryUI download configuration tool to add just the additional widgets necessary for the timepicker.

The current baseline is:

- Core
- Autocomplete
- Tabs
- Datepicker

(In reply to comment #2)
> This patch adds *all* jQueryUI interactions, widgets, and effects to Koha,
> whereas I was trying to add them only as needed. I would prefer it if you
> could use the jQueryUI download configuration tool to add just the
> additional widgets necessary for the timepicker.
> 
> The current baseline is:
> 
> - Core
> - Autocomplete
> - Tabs
> - Datepicker

Sounds OK/fair to me. What about adding a wiki page (linked to coding guidelines -maybe not coding guidelines page itself) about those rules ?

Created attachment 11196 [details]
In input field last minute is not displayed

Patch works as expected.

- Minor issue with CSS: Input field does not fully display the time (last minute not visible). See screenshot.

- Question: If an item is issued, should "Renewal due date" display time as well? 

Marc

(In reply to comment #6)
> Created attachment 11196 [details]
> In input field last minute is not displayed
> 
> Patch works as expected.
> 
> - Minor issue with CSS: Input field does not fully display the time (last
> minute not visible). See screenshot.

Fixed in new patch.

> - Question: If an item is issued, should "Renewal due date" display time as
> well? 

It already does.

Created attachment 11202 [details] [review]
[SIGNED-OFF] Bug 8498 - can't specify an hour when specifying due date

With hourly loans Koha can make items due specific hours,
but if you have the specify due date box on the checkout
screen you can't enter an hour/minute. It will always default
to 23:59.

* Add jquery timepicker plugin
* Update jquery ui to include timepicker prerequisite slider
* Set timepicker's default time to 23:59, remove the hard
  coded 23:59 setting from circulation.pl
* Resize input fields such that the entire date and time are
  visible.

Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected, input field displays entire date and time.

QA Comment: 
* Owen/Kyle, I need a confirmation: is the upgrade
- * jQuery UI CSS Framework 1.8.20
+ * jQuery UI CSS Framework 1.8.22
needed, why ? are you sure it's harmless ?


* If you don't use hourly loans, is it possible not to have the hour/minute picker ? (not sure)

Other than this, nothing against a passed QA status

Hi Paul, I think at the moment we don't have a system prefernce for hourly loans, so to not see the minutes the system would have to check the circulation rules?

I would like it a bit better too, if it possible to easily differentiate between loans in days and hourly loans. For example I think 'normal' loans shouldn't display the minute part, as it will probably be confusing to some libraries. But probably way out of scope for this bug :)

(In reply to comment #10)
> QA Comment: 
> * Owen/Kyle, I need a confirmation: is the upgrade
> - * jQuery UI CSS Framework 1.8.20
> + * jQuery UI CSS Framework 1.8.22
> needed, why ? are you sure it's harmless ?

I needed to add components that were not in our current version. The jQuery UI builder does not give the option of selecting a previous version.

> 
> * If you don't use hourly loans, is it possible not to have the hour/minute
> picker ? (not sure)

Not in this iteration, but I don't feel that it gets in the way, even if it is not hidden. We aren't hiding the hours portion of due dates anywhere else ( at least not on purpose ).

(In reply to comment #10)
> Other than this, nothing against a passed QA status

i think Kyle has answered Cait's and Paul's questions to satisfaction, so...
patch looks good, passing QA :)


mason@xen1:~/git/head$ koha-qa.pl 
        * e99beda Bug 8498 - can't specify an hour when specifying due date
                circ/circulation.pl
                koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
                koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.css
                koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.js
                koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/jquery-ui-timepicker-addon.js
                koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt

- perlcritic-progressive tests... OK
- perl -c syntax tests... OK
- xt/tt_valid.t tests... OK
- xt/author/valid-template.t tests... OK

FYI I have added (In reply to comment #3)

> Sounds OK/fair to me. What about adding a wiki page (linked to coding
> guidelines -maybe not coding guidelines page itself) about those rules ?

I updated this section with the information:

http://wiki.koha-community.org/wiki/Coding_Guidelines#Using_jQueryUI_widgets

Patch pushed to master

Does not apply to 3.8.x please submit a patch for 3.8.x if one is needed

(In reply to comment #16)
> Does not apply to 3.8.x please submit a patch for 3.8.x if one is needed

Not applicable to 3.8.x.