Summary: | Self checkout does not display debt amount if syspref AllowFineOverride is set to allow | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Self checkout | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Screenshot missing debt amount in sco
Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow |
Description
Marc Véron
2012-07-29 06:57:19 UTC
Created attachment 11182 [details]
Screenshot missing debt amount in sco
Message in German: Sie haben offene Gebühren in Höhe von und können daher nichts mehr entleihen. Message in French: Vous avez une dette de et ne pouvez pas emprunter. Created attachment 11183 [details] [review] Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow If the patron has depts that prevent issuing and the system preference 'AllowFineOverride' is set to 'allow', the amount is not displayed in the user message. Additionally, patch adds currency symbol to amount. Test plan: Do self checkout with patron who has debts that are over the limit. Test with and without preference 'AllowFineOverride' set. Created attachment 11192 [details] [review] Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow If the patron has depts that prevent issuing and the system preference 'AllowFineOverride' is set to 'allow', the amount is not displayed in the user message. Additionally, patch adds currency symbol to amount. Test plan: Do self checkout with patron who has debts that are over the limit. Test with and without preference 'AllowFineOverride' set. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Created attachment 11193 [details] [review] Bug 8518 - Self checkout does not display debt amount if syspref AllowFineOverride is set to allow If the patron has depts that prevent issuing and the system preference 'AllowFineOverride' is set to 'allow', the amount is not displayed in the user message. Additionally, patch adds currency symbol to amount. Test plan: Do self checkout with patron who has debts that are over the limit. Test with and without preference 'AllowFineOverride' set. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> QA Comments: Display a missing information. Marking as Passed QA. QA comment: would be better to introduce a library to display efficiently. Could (should ?) be a T::T plugin (In France, the currency is displayed after the number : 1234.56€ for example.) Won't reject this patch for this reason, but if you want to do it, you're highly welcomed ;-) Pushed to 3.8.x, will be in 3.8.4 |