Summary: | Markup errors cause problems with customized CSS | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, mtj, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Screenshot showing the header background problem
Bug 8522 - Markup errors cause problems with customized CSS Bug 8522 - Markup errors cause problems with customized CSS |
Created attachment 11199 [details] [review] Bug 8522 - Markup errors cause problems with customized CSS Some includes and templates contained duplicate "header" ids in the markup. The problem should have come up in routine page validation, but was obvious when custom CSS was applied. To test, load any of the affected pages and validate the generated HTML. There should be no errors about 'ID "header" already defined." Or, add custom CSS to intranetusercss: ...and confirm that only the topmost menu background is affected. Sorry, the CSS example didn't come through because it was prefixed with "#" ! #header { background : #336699 none; } Created attachment 11396 [details] [review] Bug 8522 - Markup errors cause problems with customized CSS Some includes and templates contained duplicate "header" ids in the markup. The problem should have come up in routine page validation, but was obvious when custom CSS was applied. To test, load any of the affected pages and validate the generated HTML. There should be no errors about 'ID "header" already defined." Or, add custom CSS to intranetusercss: ...and confirm that only the topmost menu background is affected. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> (In reply to comment #3) > Created attachment 11396 [details] [review] > Bug 8522 - Markup errors cause problems with customized CSS > > Some includes and templates contained duplicate "header" ids in > the markup. The problem should have come up in routine page > validation, but was obvious when custom CSS was applied. > > To test, load any of the affected pages and validate the > generated HTML. There should be no errors about 'ID "header" > already defined." Or, add custom CSS to intranetusercss: > > ...and confirm that only the topmost menu background is affected. > > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> patch look good, passing QA mason@xen1:~/git/head$ koha-qa.pl * e6a5599 Bug 8522 - Markup errors cause problems with customized CSS koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/cities-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/patrons-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/roadtype-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/z3950-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK mason@xen1:~/git/head$ Pushed to 3.8.x will be in 3.8.4 Patch pushed to master. Already on stable, setting status accordingly |
Created attachment 11198 [details] Screenshot showing the header background problem A few files have markup errors which are causing display problems when a custom stylesheet is set up to override the background of the #header region.