Summary: | Add callnumber sort option to overdue report | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Circulation | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, baptiste.wojtkowski, gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall, kyle, m.de.rooy, marjorie.barry-vila, nick, oleonard, veron |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: |
Bug 8548: Add datatable to circ overdue report, remove sortby filter
[SIGNED OFF] Bug 8548: Add datatable to circ overdue report, remove sortby filter Bug 8548: Add datatable to circ overdue report, remove sortby filter Bug 8548: Add datatable to circ overdue report, remove sortby filter Bug 8548: Add datatable to circ overdue report, remove sortby filter |
Description
Nicole C. Engard
2012-08-01 12:22:00 UTC
I think ideally we should make all the columns sortable there using a datatable. Hm, as there is a specific sorting option in the search form, it might be easier to add a sort on cn_sort or itemcallnumber? Created attachment 60170 [details] [review] Bug 8548: Add datatable to circ overdue report, remove sortby filter This patch adds a datatable to the circ overdue report. Since the datatable makes sorting easy, I've also removed the sort by filter on the side. To test: 1) Go to Circulation -> Overdues 2) Notice overdues report shows as datatable 3) Confirm sorting on all columns works 4) Test the Filters and confirm they all still work as expected Sponsored-by: Catalyst IT Created attachment 60466 [details] [review] [SIGNED OFF] Bug 8548: Add datatable to circ overdue report, remove sortby filter This patch adds a datatable to the circ overdue report. Since the datatable makes sorting easy, I've also removed the sort by filter on the side. To test: 1) Go to Circulation -> Overdues 2) Notice overdues report shows as datatable 3) Confirm sorting on all columns works 4) Test the Filters and confirm they all still work as expected Sponsored-by: Catalyst IT Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Aleisha, it seems that there is still code related to the "order" parameter. I guess we should get rid of it as well (search for '$order' in the pl script). Created attachment 60483 [details] [review] Bug 8548: Add datatable to circ overdue report, remove sortby filter This patch adds a datatable to the circ overdue report. Since the datatable makes sorting easy, I've also removed the sort by filter on the side. To test: 1) Go to Circulation -> Overdues 2) Notice overdues report shows as datatable 3) Confirm sorting on all columns works 4) Test the Filters and confirm they all still work as expected Sponsored-by: Catalyst IT Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Created attachment 60484 [details] [review] Bug 8548: Add datatable to circ overdue report, remove sortby filter This patch adds a datatable to the circ overdue report. Since the datatable makes sorting easy, I've also removed the sort by filter on the side. To test: 1) Go to Circulation -> Overdues 2) Notice overdues report shows as datatable 3) Confirm sorting on all columns works 4) Test the Filters and confirm they all still work as expected Sponsored-by: Catalyst IT Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Aleisha, Sorry it seems that I missed something in my previous tests: If you remove the sort "filter" we are going to loose the ability to export sorted results. I am not sure if it's a big deal as it's easily feasible using LibreOffice (or similar). I'd like to get other opinions here. I think you are right Jonathan, once the results are exported the end user can sort in whichever program they use. These patches are a nice improvement on the overdues screen Created attachment 61302 [details] [review] Bug 8548: Add datatable to circ overdue report, remove sortby filter This patch adds a datatable to the circ overdue report. Since the datatable makes sorting easy, I've also removed the sort by filter on the side. To test: 1) Go to Circulation -> Overdues 2) Notice overdues report shows as datatable 3) Confirm sorting on all columns works 4) Test the Filters and confirm they all still work as expected Sponsored-by: Catalyst IT Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Aleisha! Nice patch, but I think more an enhancement than a bug fix! This patch has been pushed to 16.11.x and will be in 16.11.07. (In reply to Katrin Fischer from comment #12) > Nice patch, but I think more an enhancement than a bug fix! > > This patch has been pushed to 16.11.x and will be in 16.11.07. Could not find this patch in 16.11.x (even higher than .07) Probably a copy-paste error here.. Likely a typo, also judging from the first comment. |