Bug 8596

Summary:	Reports interface date picker doesn't force ISO formatted dates
Product:	Koha	Reporter:	Robin Sheat <robin>
Component:	Reports	Assignee:	Owen Leonard <oleonard>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P5 - low	CC:	chris, koha.sekjal, nengard, paul.poulain
Version:	3.8
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	---
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:
Circulation function:
Attachments:	Bug 8596 - Reports interface date picker doesn't force ISO formatted dates [SIGNED-OFF] Bug 8596 - Reports interface date picker doesn't force ISO formatted dates

Description Robin Sheat 2012-08-08 15:11:07 UTC

If you create a report with <<Enter a date|date>>, the resulting date picker interface when running the report doesn't force dates to ISO form, instead they are created using the date format of the system. This is passed to mysql which complains about the format not being right, understandably.

Comment 1 Owen Leonard 2012-08-14 14:15:50 UTC Comment hidden (obsolete)

Created attachment 11605 [details] [review]
Bug 8596 - Reports interface date picker doesn't force ISO formatted dates

Datepickers follow Koha's preference for date format, but the
guided reports system doesn't intelligently handle different date
formats. ISO is required. This patch adds some additional
configuration to override the date format.

To test, create a guided or SQL report which takes a date
parameter. The datepicker fields should return an ISO-formatted
date.

Comment 2 Nicole C. Engard 2012-08-16 17:16:33 UTC

Created attachment 11645 [details] [review]
[SIGNED-OFF] Bug 8596 - Reports interface date picker doesn't force ISO formatted dates

Datepickers follow Koha's preference for date format, but the
guided reports system doesn't intelligently handle different date
formats. ISO is required. This patch adds some additional
configuration to override the date format.

To test, create a guided or SQL report which takes a date
parameter. The datepicker fields should return an ISO-formatted
date.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Works as advertised.

Comment 3 Ian Walls 2012-08-17 15:06:29 UTC

Adds date formatting according to datepicker's conventions (which do yyyy-mm-dd even though it says yy-mm-dd).

Passed QA.

Comment 4 Paul Poulain 2012-08-29 16:25:56 UTC

QA It would have been better to handle the syspref properly, but I agree it would have required a larger rewrite. And, as we're dealing with reports/sql/..., which is used by a limited number of patrons, I agree it's fair to force iso.

Patch pushed

Comment 5 Chris Cormack 2012-08-29 22:13:20 UTC

Pushed to 3.8.x will be in 3.8.5