Description
Magnus Enger
2012-08-13 10:42:22 UTC
Created attachment 42703 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Created attachment 42704 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Created attachment 45968 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 45969 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) Martin, Following the coding guidelines, new modules added to the Koha namespace should be object-oriented. You should have a look at Koha::Object ( see Koha::Patron::Categories and Koha::Virtualshel* for examples). Created attachment 58602 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland Created attachment 58603 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 58604 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) Created attachment 58605 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland This patch should now apply cleanly and is ready for testing. Created attachment 62338 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland The QA scripts are pointing out some issues with these patches: FAIL installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 1 simicolon found instead of comma at line 3 simicolon found instead of comma at line 2 OK sysprefs_order FAIL installer/data/mysql/kohastructure.sql FAIL charset_collate The table sign_streams does not have the current charset collate (see bug 11944) The table signs_to_streams does not have the current charset collate (see bug 11944) The table signs does not have the current charset collate (see bug 11944) OK git manipulation OK installer/data/mysql/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt FAIL forbidden patterns forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 407) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 441) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 227) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 86) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 87) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 226) forbidden pattern: Contains old bootstrap style for buttons (see bug 16239) (line 442) OK git manipulation OK spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt OK forbidden patterns OK git manipulation OK spelling OK tt_valid OK valid_template FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL forbidden patterns forbidden pattern: simple-quote string (line 468) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 561) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 67) forbidden pattern: simple-quote string (line 464) forbidden pattern: simple-quote string (line 448) forbidden pattern: simple-quote string (line 450) forbidden pattern: simple-quote string (line 465) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 462) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 70) forbidden pattern: simple-quote string (line 478) forbidden pattern: opac-tmpl should certainly replaced with [% interface %] (line 69) OK git manipulation FAIL spelling initilize ==> initialize OK tt_valid OK valid_template FAIL opac/opac-signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid FAIL tools/signs.pl OK critic FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) OK git manipulation OK pod OK spelling OK valid Took a quick look at the code of the patches too: 1) There is an atomicupdate for adding a new permission edit_digital_signs, but no corresponding change to koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc 2) Maybe a merge issue, but sysprefs.sql removes 2 existing system preferences and doesn't add the new ones? 3) There is a comment about YUI - maybe that can just be thrown out? + // prepare DOM for YUI Toolbar 4) the borrow permission is used in opac-signs.pl but has since been removed. Created attachment 64249 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies I tried to fix the conflicts in kohastructure.sql, but ended with: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 8628: [FOLLOW-UP] More fixes fatal: sha1 information is lacking or useless (installer/data/mysql/kohastructure.sql). error: could not build fake ancestor Patch failed at 0001 Bug 8628: [FOLLOW-UP] More fixes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8628-FOLLOW-UP-More-fixes-banEXL.patch Can you please take a look? Created attachment 66246 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland Created attachment 66247 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 66248 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) Created attachment 66249 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies Created attachment 66250 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland Sorry about all that - looks like the patches apply without conflicts now. Ready to test. Is it correct that this bug depends on Bug 8630? Trying to test :) - Nothing found in code review. - Database update works nicely. Not OK: - QA test tools give some bad results: FAIL Koha/Schema/Result/Sign.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Schema/Result/SignStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Schema/Result/SignsToStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/Sign.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/SignStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL Koha/SignsToStream.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage OK spelling OK valid FAIL installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql OK git manipulation FAIL semicolon OK sysprefs_order FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL forbidden patterns OK git manipulation FAIL spelling OK tt_valid OK valid_template - On the /cgi-bin/koha/tools/signs.pl the datatable is broken (next page, etc.) - I think it would be nicer to use "SIGN" instead of "SIG" for the report group and include it in the sample values. - On point 16) of the test plan I receive an internal server error, so can't test the last steps: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Biblio.pm line 1182. I wonder if this would be better as a plugin... It might be an option. But I really wish we could fix the translation problem of plugins so that we can really have fun with them. Created attachment 77025 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 77026 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) Created attachment 77027 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies Created attachment 77028 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland Created attachment 77141 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 77142 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) Created attachment 77143 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies Created attachment 77144 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland Created attachment 77145 [details] [review] Bug 8628: [FOLLOW-UP] Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors) Tested in Biblibre Sandbox 1 -- Digital signs does not appear under Tools/Additional Tools. cgi-bin/koha/opac-signs.pl not found on server. OPACDigitalSigns system preference is added. Created attachment 78709 [details]
Screenshot of the test.
When creating a stream, I was not forced to NAME the stream, meaning it was unavailable to select for the sign. The test plan did not call for naming the stream. I have also attached a screen shot showing the following results:
Images, local or otherwise, do now show.
The listed titles below seem to be both showing up at the same time.
(In reply to Spencer from comment #36) Thanks for testing this Spencer! If the patches do not work as they should, you can change the status to "Failed QA" (and save some kittens) Created attachment 80248 [details] [review] Bug 8628: [FOLLOW-UP] More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies Created attachment 80249 [details] [review] Bug 8628: [FOLLOW-UP] Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland Created attachment 80250 [details] [review] Bug 8628: [FOLLOW-UP] Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors) Created attachment 80252 [details] [review] Bug 8628: (follow-up) Some template fixes This patch: - makes the stream name a required field - fixes the link to the OPAC sign view - fixes the toolbar in staff side Still have not fixed the overlapping of titles. Created attachment 82896 [details] [review] Bug 8628: Add digital signs to the OPAC, dbchanges Database changes for bug 8628 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Created attachment 82897 [details] [review] Bug 8628: Add digital signs to the OPAC See http://wiki.koha-community.org/wiki/Digital_signs_RFC for details. To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIG, you should be warned that there are no reports in the group with code SIG and given a link for creating a new report. Follow the link and create a new report with report group code SIG. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> In theory this could/should be rewritten to use Koha::Schema instead of direct sql, but this predates the switch, so would be unfair to reject it on that basis (plus until we fix the speed straight sql is way faster anyway) Created attachment 82898 [details] [review] Bug 8628: (follow-up) More fixes This patch fixes qa tool issues, problems in comment 13, merge conflicts, other issues with patches Same test plan applies Created attachment 82899 [details] [review] Bug 8628: (follow-up) Add digital signs to the OPAC This patch rewrites all modules from the original patch to be object oriented. Follows above test plan. Sponsored-by: Region Halland Created attachment 82900 [details] [review] Bug 8628: (follow-up) Fixing internal server error and rebase issues This patch addresses the comments in Comment 23 Test that 1) all qa test tools pass 2) datatable on tools/signs.pl is not broken 3) features uses report group "SIGN" instead of "SIG" 4) you can complete the main test plan (no server errors) Created attachment 82901 [details] [review] Bug 8628: (follow-up) Some template fixes This patch: - makes the stream name a required field - fixes the link to the OPAC sign view - fixes the toolbar in staff side Still have not fixed the overlapping of titles. Created attachment 83312 [details] [review] Bug 8628: (follow-up) Fixing CSS so titles don't overlap I have amended the CSS so the titles sit side-by-side rather than on top of each other. Please rebase on master. Created attachment 88821 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Created attachment 88822 [details] [review] Bug 8628: Digital signs - schema updates Created attachment 88823 [details] [review] Bug 8628: Digital signs - Koha objects Created attachment 88824 [details] [review] Bug 8628: Digital signs - preferences and permissions Created attachment 88825 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Created attachment 88826 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Created attachment 93054 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Created attachment 93055 [details] [review] Bug 8628: Digital signs - schema updates Created attachment 93056 [details] [review] Bug 8628: Digital signs - Koha objects Created attachment 93057 [details] [review] Bug 8628: Digital signs - preferences and permissions Created attachment 93058 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Created attachment 93059 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Minor rebase on kohastructure Created attachment 93066 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 93067 [details] [review] Bug 8628: Digital signs - schema updates Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 93068 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 93069 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 93070 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 93071 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Hi Aleisha, this no longer applies, can you please rebase and run QA tools on the set? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8628: Digital signs - db changes Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/sysprefs.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 8628: Digital signs - db changes Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8628-Digital-signs---db-changes-T0d215.patch Created attachment 99608 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99609 [details] [review] Bug 8628: Digital signs - schema updates Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99610 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99611 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99612 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99613 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99614 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update Created attachment 99615 [details] [review] Bug 8628: (follow-up) Fixing 'UseKohaPlugins' for qa tools Created attachment 99616 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference Created attachment 99617 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99618 [details] [review] Bug 8628: Digital signs - schema updates Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99619 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99620 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99621 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99622 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 99623 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update Created attachment 99624 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference Sorry for all the attachments! Ready to test I'm getting this error: Template process failed: undef error - DBIC result _type isn't of the _type SavedSql at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 419. at /kohadevbox/koha/C4/Templates.pm line 122 Did I miss a step in the setup? (In reply to Owen Leonard from comment #88) > I'm getting this error: > > Template process failed: undef error - DBIC result _type isn't of the _type > SavedSql at > /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line > 419. > at /kohadevbox/koha/C4/Templates.pm line 122 > > > Did I miss a step in the setup? Hi Owen You may need to update the schema files and restart memcached because of the db changes I'm getting an error when running the database update: DEV atomic update: bug_8628-digital-signs-permissions.perl Upgrade to XXX done (Bug 8628 - adding permission for managing digital signs) DEV atomic update: bug_8628-digital-signs-sysprefs.perl Upgrade to XXX done (Bug 8628 - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences) DEV atomic update: bug_8628-digital-signs.perl DBD::mysql::db do failed: Unknown collation: 'utf8mb4' [for Statement " CREATE TABLE sign_streams ( sign_stream_id int(11) NOT NULL auto_increment, -- primary key, used to identify streams saved_sql_id int(11) NOT NULL, -- foreign key from the saved_sql table name varchar(64), -- name/title of the sign PRIMARY KEY (sign_stream_id), CONSTRAINT sign_streams_ibfk_1 FOREIGN KEY (saved_sql_id) REFERENCES saved_sql (id) ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4 "] at (eval 1419) line 6. DBD::mysql::db do failed: Can't create table 'koha_kohadev.signs_to_streams' (errno: 150) [for Statement " CREATE TABLE signs_to_streams ( sign_to_stream_id int(11) NOT NULL auto_increment, -- primary key, used to identify connections between signs and streams (the same stream can be attached to a sign more than once, with different parameters) sign_stream_id int(11) NOT NULL, -- foreign key from the decks sign_streams table sign_id int(11) NOT NULL, -- foreign key from the signs table params varchar(255) NOT NULL DEFAULT '', -- list of parameters for the SQL associated with the sign_stream PRIMARY KEY (sign_to_stream_id), CONSTRAINT signs_to_streams_ibfk_1 FOREIGN KEY (sign_stream_id) REFERENCES sign_streams (sign_stream_id) ON DELETE CASCADE, CONSTRAINT signs_to_streams_ibfk_2 FOREIGN KEY (sign_id) REFERENCES signs (sign_id) ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci "] at (eval 1419) line 34. Upgrade to XXX done (Bug 8628 - add signs, sign_streams and signs_to_streams tables) Created attachment 99717 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update Created attachment 99718 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference (In reply to David Nind from comment #90) > I'm getting an error when running the database update: oops! this should be fixed now Created attachment 99801 [details]
Screenshots - screens not aligned correctly
It may be my setup (using koha-testing-docker) but I can't seem to get the staff interface screens and the signage to display correctly (Firefox, Google Chrome, and Chromium on Ubuntu 18.04).
In the staff interface the add and edit screens take up the whole width of the screen, and the other tools menu items are pushed to the bottom.
On the signage screens, things don't display correctly.
Screenshots attached.
Notes from testing :
- Apply patches
- Run updatedatabase
- Run dbic
- flush_memcached
- restart_all
(In reply to David Nind from comment #94) > > In the staff interface the add and edit screens take up the whole width of > the screen, and the other tools menu items are pushed to the bottom. Will look into this > > On the signage screens, things don't display correctly. Can you please advise what 'correctly' should look like? I took this patch over from someone else and the signs have always displayed for me the way they do in your screenshots. How do you expect them to look? I'm not sure what 'correct' should look like, and was going off the original mockups at https://wiki.koha-community.org/wiki/Digital_signs_RFC I guess I was expecting the covers (if they exist) to display. When you click (or touch on a touch screen) an item it will pop up with the details. You can then continue paging through. Created attachment 118472 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 118473 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 118474 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 118475 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 118476 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 118477 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update Created attachment 118478 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference Created attachment 118479 [details] [review] Bug 8628: Updated schema files Created attachment 118480 [details] [review] Bug 8628: (follow-up) Fix layout of signs admin page (In reply to David Nind from comment #96) > I'm not sure what 'correct' should look like, and was going off the original > mockups at https://wiki.koha-community.org/wiki/Digital_signs_RFC > > I guess I was expecting the covers (if they exist) to display. When you > click (or touch on a touch screen) an item it will pop up with the details. > You can then continue paging through. Cool it looks right to me! So you first see a wall of covers, when you click on one it shows that record in a 'shelf' view, with one or two covers on either side of the clicked on, plus some info about items. You can click on the covers on the shelf to go to them, or go 'Back' to go back to the wall! Created attachment 119455 [details] [review] Bug 8628: (follow-up) Fix layout of signs admin page Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> I didn't get the covers to show, even if some of the books had covers. Tested in a sandbox with Firefox and didn't manage to drag the books. Oterwise it worked as described in the test plan. I would recommend running qa tools yourself too :) Lots of warnings, especially on filters. But some interesting other ones too ;) Processing files before patches |========================>| 20 / 20 (100.00%) Processing files after patches File not found : lib/jquery/mobile/jquery.mobile.min.css at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 107. File not found : lib/jquery/mobile/jquery.mobile.min.js at /usr/share/koha/Koha/Template/Plugin/Asset.pm line 84. |========================>| 20 / 20 (100.00%) OK Koha/Schema/Result/SavedSql.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/Schema/Result/Sign.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK valid FAIL Koha/Schema/Result/SignStream.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK valid FAIL Koha/Schema/Result/SignsToStream.pm OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK valid FAIL Koha/Sign.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 SKIP spelling OK valid FAIL Koha/SignStream.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/SignStreams.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/Signs.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/SignsToStream.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL Koha/SignsToStreams.pm OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod OK pod coverage SKIP spelling OK valid FAIL installer/data/mysql/kohastructure.sql FAIL boolean_vs_tinyint WARNING - The new column (webapp) for table signs is using INT(1) as type, must be TINYINT(1) if it has a boolean purpose, see the SQL12 coding guideline OK charset_collate OK git manipulation OK tinyint_has_boolean_flag OK installer/data/mysql/mandatory/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt FAIL filters missing_filter at line 18 ( [% INCLUDE dslink %] Edit "[% stream.name %]") missing_filter at line 24 ( [% INCLUDE dslink %] Edit "[% sign.name %]") missing_filter at line 29 ( [% INCLUDE dslink %] Edit streams attached to "[% sign.name %]") wrong_html_filter at line 32 ( <a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% sign.sign_id %]">Edit streams attached to "[% sign.name %]"</a> ›) missing_filter at line 32 ( <a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% sign.sign_id %]">Edit streams attached to "[% sign.name %]"</a> ›) missing_filter at line 32 ( <a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% sign.sign_id %]">Edit streams attached to "[% sign.name %]"</a> ›) missing_filter at line 35 ( [% INCLUDE dslink %] Delete stream "[% stream.name %]") missing_filter at line 39 ( [% INCLUDE dslink %] Delete sign "[% sign.name %]") missing_filter at line 82 ( <form action="[% script_name %]" name="streamform" id="streamform" method="post">) missing_filter at line 85 ( <input type="hidden" name="sign_stream_id" value="[% stream.sign_stream_id %]" />) missing_filter at line 91 ( <input type="text" name="name" value="[% stream.name %]" required="required">) missing_filter at line 101 ( <option value="[% report.id %]" selected="selected">[% report.report_name %]</option>) missing_filter at line 101 ( <option value="[% report.id %]" selected="selected">[% report.report_name %]</option>) missing_filter at line 103 ( <option value="[% report.id %]">[% report.report_name %]</option>) missing_filter at line 103 ( <option value="[% report.id %]">[% report.report_name %]</option>) missing_filter at line 121 ( <form action="[% script_name %]" name="signform" id="signform" method="post">) missing_filter at line 124 ( <input type="hidden" name="sign_id" value="[% sign.sign_id %]" />) missing_filter at line 129 ( <li><label for="name">Name</label><input type="text" name="name" value="[% sign.name %]" /></li>) missing_filter at line 150 ( <option value="[% swatch %]" selected="selected">[% swatch %]</option>) missing_filter at line 150 ( <option value="[% swatch %]" selected="selected">[% swatch %]</option>) missing_filter at line 152 ( <option value="[% swatch %]">[% swatch %]</option>) missing_filter at line 152 ( <option value="[% swatch %]">[% swatch %]</option>) missing_filter at line 161 ( <option value="[% transition %]" selected="selected">[% transition %]</option>) missing_filter at line 161 ( <option value="[% transition %]" selected="selected">[% transition %]</option>) missing_filter at line 163 ( <option value="[% transition %]">[% transition %]</option>) missing_filter at line 163 ( <option value="[% transition %]">[% transition %]</option>) missing_filter at line 174 ( <input type="text" name="idleafter" id="idleafter" value="[% sign.idleafter %]" size="4" /> seconds. (Set to 0 to disable automatic page turning.)) missing_filter at line 177 ( <input type="text" name="pagedelay" id="pagedelay" value="[% sign.pagedelay %]" size="4" /> seconds.) missing_filter at line 180 ( <input type="text" name="reloadafter" id="reloadafter" value="[% sign.reloadafter %]" size="4" /> seconds.) missing_filter at line 188 ( <h1>Edit streams attached to [% sign.name %]</h1>) missing_filter at line 202 ( <td>[% s.sign_stream.name %]</td>) missing_filter at line 203 ( <td>[% IF s.params %][% s.params %][% ELSE %]None[% END %]</td>) wrong_html_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) wrong_html_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) wrong_html_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) missing_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) missing_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) missing_filter at line 206 ( <a href="/cgi-bin/koha/tools/signs.pl?op=get_params&sign_to_stream_id=[% s.sign_to_stream_id %]&sign_stream_id=[% s.sign_stream_id %]&sign_id=[% s.sign_id %]" class="btn btn-default btn-xs" title="Edit parameters"><i class="fa fa-pencil"></i></a>) wrong_html_filter at line 208 ( <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% s.sign_stream.saved_sql_id %]&phase=Edit SQL" class="btn btn-default btn-xs" title="Edit SQL"><i class="fa fa-pencil"></i></a>) missing_filter at line 208 ( <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% s.sign_stream.saved_sql_id %]&phase=Edit SQL" class="btn btn-default btn-xs" title="Edit SQL"><i class="fa fa-pencil"></i></a>) wrong_html_filter at line 211 ( <td class="actions"><a href="/cgi-bin/koha/tools/signs.pl?op=detach_stream_from_sign&sign_id=[% s.sign_id %]&sign_to_stream_id=[% s.sign_to_stream_id %]" class="btn btn-default btn-xs detach"><i class="fa fa-times"></i> Detach</a></td>) wrong_html_filter at line 211 ( <td class="actions"><a href="/cgi-bin/koha/tools/signs.pl?op=detach_stream_from_sign&sign_id=[% s.sign_id %]&sign_to_stream_id=[% s.sign_to_stream_id %]" class="btn btn-default btn-xs detach"><i class="fa fa-times"></i> Detach</a></td>) missing_filter at line 211 ( <td class="actions"><a href="/cgi-bin/koha/tools/signs.pl?op=detach_stream_from_sign&sign_id=[% s.sign_id %]&sign_to_stream_id=[% s.sign_to_stream_id %]" class="btn btn-default btn-xs detach"><i class="fa fa-times"></i> Detach</a></td>) missing_filter at line 211 ( <td class="actions"><a href="/cgi-bin/koha/tools/signs.pl?op=detach_stream_from_sign&sign_id=[% s.sign_id %]&sign_to_stream_id=[% s.sign_to_stream_id %]" class="btn btn-default btn-xs detach"><i class="fa fa-times"></i> Detach</a></td>) missing_filter at line 221 ( <form action="[% script_name %]" name="attach_stream_to_sign_form" id="attach_stream_to_sign_form" method="post">) missing_filter at line 223 ( <input type="hidden" name="sign_id" value="[% sign_id %]" />) missing_filter at line 229 ( <option value="[% s.sign_stream_id %]">[% s.name %]</option>) missing_filter at line 229 ( <option value="[% s.sign_stream_id %]">[% s.name %]</option>) missing_filter at line 239 ( <h1>Parameters for [% stream.name %]</h1>) wrong_html_filter at line 240 ( Based on report: [% sql.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 240 ( Based on report: [% sql.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 240 ( Based on report: [% sql.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 242 ( <form action="[% script_name %]" name="get_params_form" id="get_params_form" method="post">) missing_filter at line 244 ( <input type="hidden" name="sign_to_stream_id" value="[% sign_to_stream_id %]" />) missing_filter at line 245 ( <input type="hidden" name="sign_stream_id" value="[% sign_stream_id %]" />) missing_filter at line 246 ( <input type="hidden" name="sign_id" value="[% sign_id %]" />) missing_filter at line 255 ( <input type="text" size="60" name="parameters" id="parameters" value="[% sts.params %]" />) missing_filter at line 277 ( <h3>Confirm deletion of stream <span class="ex">'[% stream.name %]'</span>?</h3>) missing_filter at line 278 ( <form action="[% script_name %]" id ="confirm_stream_delete_form" method="post">) missing_filter at line 280 ( <input type="hidden" name="sign_stream_id" value="[% stream.sign_stream_id %]" />) missing_filter at line 284 ( <form action="[% script_name %]" id="cancel_stream_delete_form" method="get">) missing_filter at line 292 ( <form action="[% script_name %]" method="get">) missing_filter at line 299 ( <h3>Confirm deletion of sign <span class="ex">'[% sign.name %]'</span>?</h3>) missing_filter at line 300 ( <form action="[% script_name %]" id ="confirm_sign_delete_form" method="post">) missing_filter at line 302 ( <input type="hidden" name="sign_id" value="[% sign.sign_id %]" />) missing_filter at line 306 ( <form action="[% script_name %]" id="cancel_sign_delete_form" method="get">) missing_filter at line 314 ( <form action="[% script_name %]" method="get">) missing_filter at line 320 ( <h1>[% sign.name %]</h1>) missing_filter at line 325 ( <h3>[% stream.sign_stream.name %]</h3>) wrong_html_filter at line 328 ( <li><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% record.biblionumber %]">[% record.title %]</a></li>) missing_filter at line 328 ( <li><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% record.biblionumber %]">[% record.title %]</a></li>) missing_filter at line 328 ( <li><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% record.biblionumber %]">[% record.title %]</a></li>) missing_filter at line 337 ( <h1>[% stream.name %]</h1>) wrong_html_filter at line 338 ( Based on report: [% stream.saved_sql_id.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 338 ( Based on report: [% stream.saved_sql_id.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) missing_filter at line 338 ( Based on report: [% stream.saved_sql_id.report_name %] | <a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% stream.saved_sql_id %]&phase=Edit SQL">Edit this report</a>) wrong_html_filter at line 377 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id %]">[% s.name %]</a></td>) missing_filter at line 377 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id %]">[% s.name %]</a></td>) missing_filter at line 377 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id %]">[% s.name %]</a></td>) missing_filter at line 379 ( <td>[% s.swatch %]</td>) missing_filter at line 380 ( <td>[% s.transition %]</td>) missing_filter at line 381 ( <td>[% s.idleafter %]</td>) missing_filter at line 382 ( <td>[% s.pagedelay %]</td>) missing_filter at line 383 ( <td>[% s.reloadafter %]</td>) missing_filter at line 386 ( <a class="btn btn-default btn-xs dropdown-toggle" id="opensignsactions[% s.sign_id %]" role="button" data-toggle="dropdown" href="#"> Actions <b class="caret"></b></a>) missing_filter at line 387 ( <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="opensignsactions[% s.sign_id %]">) wrong_html_filter at line 388 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=edit_sign&sign_id=[% s.sign_id %]"><i class="fa fa-pencil"></i> Edit</a></li>) missing_filter at line 388 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=edit_sign&sign_id=[% s.sign_id %]"><i class="fa fa-pencil"></i> Edit</a></li>) wrong_html_filter at line 389 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% s.sign_id %]"><i class="fa fa-pencil"></i> Edit streams</a></li>) missing_filter at line 389 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=edit_streams&sign_id=[% s.sign_id %]"><i class="fa fa-pencil"></i> Edit streams</a></li>) wrong_html_filter at line 390 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=del_sign&sign_id=[% s.sign_id %]"><i class="fa fa-trash"></i> Delete</a></li>) missing_filter at line 390 ( <li><a href="/cgi-bin/koha/tools/signs.pl?op=del_sign&sign_id=[% s.sign_id %]"><i class="fa fa-trash"></i> Delete</a></li>) wrong_html_filter at line 391 ( [% IF ( OPACBaseURL ) %]<li><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-signs.pl?sign=[% s.sign_id %]" title="View this sign in the OPAC"><i class="fa fa-eye"></i> View sign</a></li>[% END %]) wrong_html_filter at line 391 ( [% IF ( OPACBaseURL ) %]<li><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-signs.pl?sign=[% s.sign_id %]" title="View this sign in the OPAC"><i class="fa fa-eye"></i> View sign</a></li>[% END %]) missing_filter at line 391 ( [% IF ( OPACBaseURL ) %]<li><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-signs.pl?sign=[% s.sign_id %]" title="View this sign in the OPAC"><i class="fa fa-eye"></i> View sign</a></li>[% END %]) missing_filter at line 391 ( [% IF ( OPACBaseURL ) %]<li><a href="[% OPACBaseURL %]/cgi-bin/koha/opac-signs.pl?sign=[% s.sign_id %]" title="View this sign in the OPAC"><i class="fa fa-eye"></i> View sign</a></li>[% END %]) wrong_html_filter at line 417 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[% s.sign_stream_id %]">[% s.name %]</a></td>) missing_filter at line 417 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[% s.sign_stream_id %]">[% s.name %]</a></td>) missing_filter at line 417 ( <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[% s.sign_stream_id %]">[% s.name %]</a></td>) missing_filter at line 418 ( <td title="ID: [% s.saved_sql_id %]">[% s.saved_sql.report_name %]</td>) missing_filter at line 418 ( <td title="ID: [% s.saved_sql_id %]">[% s.saved_sql.report_name %]</td>) missing_filter at line 420 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/tools/signs.pl?op=edit_stream&sign_stream_id=[% s.sign_stream_id %]"><i class="fa fa-pencil"></i> Edit</a>) missing_filter at line 421 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/tools/signs.pl?op=del_stream&sign_stream_id=[% s.sign_stream_id %]"><i class="fa fa-trash"></i> Delete</a>) missing_filter at line 483 ( <tr><td>[% r.biblionumber %]</td><td>[% r.title %]</td></tr>) missing_filter at line 483 ( <tr><td>[% r.biblionumber %]</td><td>[% r.title %]</td></tr>) FAIL forbidden patterns forbidden pattern: Title elements must start with the unique information (bug 26703) (line 5) OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt OK filters OK forbidden patterns OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template OK koha-tmpl/intranet-tmpl/prog/js/tools-menu.js OK ES template literals OK git manipulation FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt FAIL filters missing_filter at line 23 ( [%-%]In transit from [%- item.transfertfrom %] to [%- item.transfertto %] since [%- item.transfertwhen | $KohaDates %]) missing_filter at line 23 ( [%-%]In transit from [%- item.transfertfrom %] to [%- item.transfertto %] since [%- item.transfertwhen | $KohaDates %]) missing_filter at line 36 ( [%- item.notforloanvalueopac -%] [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 36 ( [%- item.notforloanvalueopac -%] [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 38 ( [%-%]Not for loan [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 42 ( [%-%]Not for loan [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 53 ( [%-%]Available [%- IF ( item.restrictedopac ) -%] ([%- item.restrictedopac -%])[%- END -%]) missing_filter at line 58 (<title>[% IF ( sign ) %][% sign.name %] - Koha[% ELSE %]Koha digital signs[% END %]</title>) missing_filter at line 66 ( [% Koha.Preference( 'OPACDigitalSignsCSS' ) %]) asset_must_be_raw at line 68 ( [% Asset.css("lib/jquery/mobile/jquery.mobile.structure.min.css") %]) asset_must_be_raw at line 70 ( [% Asset.css("css/signs.css") %]) asset_must_be_raw at line 71 ( [% Asset.css("lib/jquery/mobile/jquery.mobile.min.css") %]) missing_filter at line 86 ( <div data-role="page" class="page-stream" data-stream-id="[% s.sign_stream_id %]" data-theme="[% sign.swatch %]" id="stream_[% s.sign_stream_id %]">) missing_filter at line 86 ( <div data-role="page" class="page-stream" data-stream-id="[% s.sign_stream_id %]" data-theme="[% sign.swatch %]" id="stream_[% s.sign_stream_id %]">) missing_filter at line 86 ( <div data-role="page" class="page-stream" data-stream-id="[% s.sign_stream_id %]" data-theme="[% sign.swatch %]" id="stream_[% s.sign_stream_id %]">) missing_filter at line 87 ( <div data-role="header" data-theme="[% sign.swatch %]" data-position="fixed">) wrong_html_filter at line 93 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream stream-active" data-inline="true" data-icon="star" data-role="button">[% stream.name %]</a>) missing_filter at line 93 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream stream-active" data-inline="true" data-icon="star" data-role="button">[% stream.name %]</a>) missing_filter at line 93 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream stream-active" data-inline="true" data-icon="star" data-role="button">[% stream.name %]</a>) missing_filter at line 93 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream stream-active" data-inline="true" data-icon="star" data-role="button">[% stream.name %]</a>) wrong_html_filter at line 95 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream" data-inline="true" data-role="button">[% stream.name %]</a>) missing_filter at line 95 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream" data-inline="true" data-role="button">[% stream.name %]</a>) missing_filter at line 95 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream" data-inline="true" data-role="button">[% stream.name %]</a>) missing_filter at line 95 ( <a href="#stream_[% stream.sign_stream_id %]" data-stream-id="[% stream.sign_stream_id %]" class="btn-stream" data-inline="true" data-role="button">[% stream.name %]</a>) missing_filter at line 101 ( <h1>[% s.name %]</h1>) wrong_html_filter at line 121 ( <li><a href="?sign=[% SIGN.sign_id %]" data-ajax="false">[% SIGN.name %]</a></li>) missing_filter at line 121 ( <li><a href="?sign=[% SIGN.sign_id %]" data-ajax="false">[% SIGN.name %]</a></li>) missing_filter at line 121 ( <li><a href="?sign=[% SIGN.sign_id %]" data-ajax="false">[% SIGN.name %]</a></li>) missing_filter at line 157 ( if (idleTime >= [% sign.idleafter %]) {) missing_filter at line 163 ( if (doIdle && idleTimePage >= [% sign.pagedelay %]) {) missing_filter at line 170 ( if (doIdle && idleTime >= [% sign.reloadafter %]) {) missing_filter at line 370 ( self.$cover.addClass('ui-bar-[% sign.swatch %]');) missing_filter at line 374 ( self.$vcontainer.addClass('ui-bar-[% sign.swatch %]');) missing_filter at line 378 ( self.$cover.css('border-color', $('.ui-bar-[% sign.swatch %]').first().css('background-color'));) missing_filter at line 397 ( var $page = $('<div data-role="page" data-close-btn="none" data-theme="[% sign.swatch %]" id="record_'+sid+'_'+cover.record.biblionumber+'"/>');) missing_filter at line 398 ( var $head = $('<div data-role="header" data-theme="[% sign.swatch %]"/>');) missing_filter at line 463 ( $li.append($('<img src="/[% interface %]/lib/famfamfam/'+item.type+'.png" class="ui-li-icon"/>'));) missing_filter at line 479 ( $foot.append($('<a href="#stream_'+sid+'" data-role="button" data-theme="[% sign.swatch %]" data-transition="[% sign.transition %]">'+_("Back")+'</a>'));) missing_filter at line 479 ( $foot.append($('<a href="#stream_'+sid+'" data-role="button" data-theme="[% sign.swatch %]" data-transition="[% sign.transition %]">'+_("Back")+'</a>'));) missing_filter at line 497 ( '[% stream.sign_stream_id %]': {) missing_filter at line 498 ( 'name': [% stream.name.json || '""' %],) missing_filter at line 501 ( {'author': [% record.author.json || '""' %],) missing_filter at line 502 ( 'title': [% record.title.json || '""' %],) missing_filter at line 503 ( 'publisher': [% record.publishercode.json || '""' %],) missing_filter at line 504 ( 'biblionumber': [% record.biblionumber.json || '""' %],) missing_filter at line 505 ( 'isbn': [% record.isbn.json || '""' %],) missing_filter at line 509 ( 'type': [% item.itemtype.json || '""' %],) missing_filter at line 511 ( 'location': [% item.location.json || '""' %],) missing_filter at line 512 ( 'location_description': [% item.location_description.json || '""' %],) missing_filter at line 513 ( 'home_branch': "[% Branches.GetName(item.homebranch) | json %]",) missing_filter at line 537 ( var $link = $('<a href="#record_'+sid+'_'+cover.record.biblionumber+'" class="btn-record" data-transition="[% sign.transition %]"/>')) missing_filter at line 539 ( $content.append($link.append($('<div class="cover placeholder ui-bar-[% sign.swatch %] cover_'+cover.id+'" data-id="'+cover.id+'"/>')));) asset_must_be_raw at line 561 ( [% Asset.js("lib/jquery/mobile/jquery.mobile.min.js") %]) FAIL forbidden patterns forbidden pattern: Attribute type should not be used for style tags (bug 20054) (line 65) forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 132) OK git manipulation OK js_in_body SKIP spelling OK tt_valid OK valid_template FAIL opac/opac-signs.pl OK critic OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) OK git manipulation OK pod SKIP spelling OK valid FAIL tools/signs.pl FAIL critic Subroutine "new" called using indirect syntax at line 48, column 11. See page 349 of PBP. OK file permissions FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 18) forbidden pattern: Script permissions is authnotrequired => 0, it could be correct for an OPAC script if it is was you really want error (bug 24663) (line 56) OK git manipulation OK pod SKIP spelling OK valid [10:16] <Joubu> but we have misc/devel/add_missing_filters.pl! Might be helpful? Created attachment 131223 [details] [review] Bug 8628: Updated schema files Created attachment 131224 [details] [review] Bug 8628: (follow-up) Fix documentation, subroutine calls, filters Bug 8628 - Add digital signs to the OPAC 118472 - Bug 8628: Digital signs - db changes 118473 - Bug 8628: Digital signs - Koha objects 118474 - Bug 8628: Digital signs - preferences and permissions 118475 - Bug 8628: Digital signs - staff interface 118476 - Bug 8628: Digital signs - opac interface 118477 - Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update 118478 - Bug 8628: (follow-up) Fixes for qa tools 119455 - Bug 8628: (follow-up) Fix layout of signs admin page 131223 - Bug 8628: Updated schema files 131224 - Bug 8628: (follow-up) Fix documentation, subroutine calls, filters Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 8628: Digital signs - db changes Applying: Bug 8628: Digital signs - Koha objects Applying: Bug 8628: Digital signs - preferences and permissions Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc error: Failed to merge in the changes. Patch failed at 0001 Bug 8628: Digital signs - preferences and permissions hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8628-Digital-signs---preferences-and-permissio-n3pr1S.patch Created attachment 145645 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 145646 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 145647 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 145648 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 145649 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 145650 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update Created attachment 145651 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference Created attachment 145652 [details] [review] Bug 8628: (follow-up) Fix layout of signs admin page Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Created attachment 145653 [details] [review] Bug 8628: (follow-up) Fix documentation, subroutine calls, filters Created attachment 145654 [details] [review] Bug 8628: Updated schema files For step 2 of the test plan I get an error trace (with OPACDigitalSigns not enabled and enabled): Template process failed: undef error - The method Koha::Signs->sign_id is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Objects.pm line 572 Koha::Objects::AUTOLOAD('Koha::Signs=HASH(0x556800cb2c48)') called at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 385 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 385 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 410 eval {...} at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 18 Template::Provider::__ANON__('Template::Context=HASH(0x556800c154e0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Document.pm line 161 Template::Document::process('Template::Document=HASH(0x556800ac9828)', 'Template::Context=HASH(0x556800c154e0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 351 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Context.pm line 321 Template::Context::process('Template::Context=HASH(0x556800c154e0)', 'Template::Document=HASH(0x556800ac9828)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 94 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template/Service.pm line 91 Template::Service::process('Template::Service=HASH(0x5568008ca520)', '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt', 'HASH(0x556800b93e68)') called at /usr/lib/x86_64-linux-gnu/perl5/5.32/Template.pm line 66 Template::process('Template=HASH(0x5568008f8190)', '/kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt', 'HASH(0x556800b93e68)', 'SCALAR(0x556800da4d88)') called at /kohadevbox/koha/C4/Templates.pm line 127 C4::Templates::output('C4::Templates=HASH(0x55680096b5e8)') called at /kohadevbox/koha/tools/signs.pl line 318 eval {...} at /kohadevbox/koha/tools/signs.pl line 2 ..... Note: I applied all the patches I have the same error as David. After I apply all the patches, I can't access to Digital signs page. I got a error 500. Trace begun at /inlibro/git/koha-master-dev-solene/Koha/Objects.pm line 572 Koha::Objects::AUTOLOAD('Koha::Signs=HASH(0x55686a4ee3b0)') called at /inlibro/git/koha-master-dev-solene/koha-tmpl/intranet-tmpl/prog/en/modules/ tools/signs.tt line 385 eval {...} at /inlibro/git/koha-master-dev-solene/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 385 eval {...} at /inlibro/git/koha-master-dev-solene/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 410 eval {...} at /inlibro/git/koha-master-dev-solene/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt line 7 Template::Document::__ANON__('Template::Context=HASH(0x55686a2e91e8)') called at /usr/lib/x86_64-linux-gnu/perl5/5.34/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.34/Template/Document.pm line 161 Template::Document::process('Template::Document=HASH(0x55686a4fbe40)', 'Template::Context=HASH(0x55686a2e91e8)') called at /usr/lib/x86_64-linux- gnu/perl5/5.34/Template/Context.pm line 351 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.34/Template/Context.pm line 321 Template::Context::process('Template::Context=HASH(0x55686a2e91e8)', 'Template::Document=HASH(0x55686a4fbe40)') called at /usr/lib/x86_64-linux- gnu/perl5/5.34/Template/Service.pm line 94 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.34/Template/Service.pm line 91 Template::Service::process('Template::Service=HASH(0x55686a2ca150)', '/inlibro/git/koha-master-dev-solene/koha-tmpl/intranet-tmpl/prog/en/modules/ tools/signs.tt', 'HASH(0x55686a527ca8)') called at /usr/lib/x86_64-linux-gnu/perl5/5.34/Template.pm line 66 Template::process('Template=HASH(0x55686121a680)', '/inlibro/git/koha-master-dev-solene/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt', 'HASH(0x55686a527ca8)', 'SCALAR(0x556863f21cf8)') called at /inlibro/git/koha-master-dev-solene/C4/Templates.pm line 127 C4::Templates::output('C4::Templates=HASH(0x55686121ac38)') called at /inlibro/git/koha-master-dev-solene/tools/signs.pl line 318 Great to see this is being kept alive after so many years! :-) I had the same initial error as David and Solene. I was able to make it go away by doing this: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt index 931079996c..f8b57c0db7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/signs.tt @@ -373,7 +373,7 @@ </tr> </thead> <tbody> - [% FOREACH s IN signs %] + [% FOREACH s IN signs.next %] <tr> <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_sign&sign_id=[% s.sign_id | uri %]">[% s.name | html %]</a></td> <td>[% IF ( s.webapp ) %]Yes[% ELSE %]No[% END %]</td> @@ -413,7 +413,7 @@ </tr> </thead> <tbody> - [% FOREACH s IN streams %] + [% FOREACH s IN streams.next %] <tr> <td><a href="/cgi-bin/koha/tools/signs.pl?op=view_stream&sign_stream_id=[% s.sign_stream_id | uri %]">[% s.name | html %]</a></td> <td title="ID: [% s.saved_sql_id | html %]">[% s.saved_sql.report_name | html %]</td> But I have problems getting the one sign I added to display, so that change might be just nonsense. I was also getting a JS error when viewing the table of signs. It seems to be am invalid value for sPaginationType, so this made the error go away: @@ -451,13 +451,13 @@ "aoColumnDefs": [ { "aTargets": [ -1 ], "bSearchable": false, "bSortable": false }, ], - "sPaginationType": "four_button" + "sPaginationType": "full" })); $("#table_streams").dataTable($.extend(true, {}, dataTablesDefaults, { "aoColumnDefs": [ { "aTargets": [ -1 ], "bSearchable": false, "bSortable": false }, ], - "sPaginationType": "four_button" + "sPaginationType": "full" })); Not sure if "full" is the pagination we want, though. This made the sign display in the main table: diff --git a/tools/signs.pl b/tools/signs.pl index e243b59b97..5b317925d0 100755 --- a/tools/signs.pl +++ b/tools/signs.pl @@ -302,12 +302,12 @@ if ( $op eq 'add_stream' ) { } else { - my @streams = Koha::SignStreams->search(); - my @signs = Koha::Signs->search(); + my $streams = Koha::SignStreams->search(); + my $signs = Koha::Signs->search(); $template->param( - streams => \@streams, - signs => \@signs, + streams => $streams, + signs => $signs, Created attachment 147000 [details] [review] Bug 8628: Digital signs - db changes - Adding edit_digital_signs permission for managing digital signs - Adding OPACDigitalSigns, OPACDigitalSignsCSS and OPACDigitalSignsSwatches system preferences - Adding signs, sign_streams and signs_to_streams tables - Updating sysprefs.sql and kohastructure.sql Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 147001 [details] [review] Bug 8628: Digital signs - Koha objects Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 147002 [details] [review] Bug 8628: Digital signs - preferences and permissions Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 147003 [details] [review] Bug 8628: Digital signs - staff interface This patch adds the interface for creating and managing digital signs and streams. Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 147004 [details] [review] Bug 8628: Digital signs - opac interface To test: 1. Apply this patch and the database updates patch 2. Run updatedatabase.pl 3. In staff client, go to Tools/Additional Tools/Digital signs 4. You should be warned about OPACDigitalSigns not being enabled, you can ignore this for now. 5. Add a new sign by clicking the "+ New sign" button 6. Enter a name and optionally numbers for automatic page turing 7. Your new sign should appear in the Signs list 8. Add a new stream by clicking the "+ New stream" button 9. Unless you already have reports in the report group with code SIGN, you should be warned that there are no reports in the group with code SIGN and given a link for creating a new report. Follow the link and create a new report with report group code SIGN. En example SQL command for the report could be: SELECT * FROM biblio WHERE timestamp > DATE_SUB(NOW(), INTERVAL 7 DAY) or if you are testing the parameters feature of the digital signs, an example report could be: SELECT * FROM biblio WHERE biblionumber < placeholder. 10. Go back to the "new stream" page, and reload. You should no longer see a warning message, and your newly created report should appear in the list of reports. 11. Select the report and click Submit. Your newly created stream should now appear in the list of streams. 12. In the list of signs, press "edit streams" for the sign you previously created. 13. Choose a stream to attach and click Submit. If you have attached a report with a parameter placeholder, edit the parameters so that the placeholder gets substituted with a value. For example, in the edit parameters box, you can have: placeholder = 10000 When you submit, you'll see the SQL replaces the placeholder with your value and completes the query. Your sign is now ready for OPAC. 14. In OPAC, visit /cgi-bin/koha/opac-signs.pl 15. You should be told that Digital signs are not enabled. Enable with new system preference OPACDigitalSigns and reload the page. 15. You should see a list of available signs, click on a sign that you wish to display. 16. You should now see a list of all books matching the SQL query in the report that you attached to your stream. 17. If you have OPACLocalCoverImages enabled, all books with local covers attached should be presented using this cover. If no local cover is available and the book has a ISBN with a cover in openlibrary.org, the cover image from openlibrary.org should be shown. If all of the above fails, a cover matching the theme of the page should be seen, showing the book title and author. 18. Clicking a book should bring you to a detailed view of the book where you can see the books availability. You should also see the two next books and the two previous books in the stream (unless you're at the beginning or end of the stream) 19. Swiping (if no touch screen, click and hold left mouse button and drag) left/right should bring you to next/previous book. Clicking on the next/previous books (right/left of the active one) should bring you to the detailed view of the clicked book. 20. Leaving the page idle (i.e no user interaction) for the amount of time specified in step 6. should result in the page automatically switching to the next book in the stream. Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Created attachment 147005 [details] [review] Bug 8628: (follow-up) Use utf8mb4 and TableExists in atomic update Created attachment 147006 [details] [review] Bug 8628: (follow-up) Fixes for qa tools using Asset and Koha.Preference Created attachment 147007 [details] [review] Bug 8628: (follow-up) Fix layout of signs admin page Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Created attachment 147008 [details] [review] Bug 8628: (follow-up) Fix documentation, subroutine calls, filters Created attachment 147009 [details] [review] Bug 8628: Updated schema files Created attachment 147010 [details] [review] Bug 8628: (follow-up) Fix search calls and table pagination When accessing the /cgi-bin/koha/opac-signs.pl, i get : Could not compile /kohadevbox/koha/opac/opac-signs.pl: "GetMarcBiblio" is not exported by the C4::Biblio module Can't continue after import errors at /kohadevbox/koha/opac/opac-signs.pl line 23. BEGIN failed--compilation aborted at /kohadevbox/koha/opac/opac-signs.pl line 23. While at this, it would be useful to optimize the steps, like setting up the prerequisit first : Creating the SIGN reports first Then the Sign stream followed be the sign itself. It's a nice feature. I would suggest to name it "Digital Signage" in order to match that kind of product (Xibo, Broadcast, ...) |