Bug 8648

Summary: searchResults uses SQL query rather than GetMarcFromKohaField
Product: Koha Reporter: Jared Camins-Esakov <jcamins>
Component: Architecture, internals, and plumbingAssignee: Jared Camins-Esakov <jcamins>
Status: CLOSED FIXED QA Contact: Jonathan Druart <jonathan.druart>
Severity: normal    
Priority: P5 - low CC: chris, jonathan.druart, julian.maurice, paul.poulain
Version: 3.8   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Who signed the patch off: Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 8649    
Attachments: Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField
[SIGNED-OFF] Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField

Description Jared Camins-Esakov 2012-08-15 16:34:27 UTC
Around line 1470-something:

    my $sth =
      $dbh->prepare(
"SELECT tagfield FROM marc_subfield_structure WHERE kohafield LIKE 'items.itemnumber'"
      );
    $sth->execute;
Comment 1 Jared Camins-Esakov 2012-08-15 19:49:36 UTC Comment hidden (obsolete)
Comment 2 Julian Maurice 2012-08-16 09:48:24 UTC
Created attachment 11635 [details] [review]
[SIGNED-OFF] Bug 8648: searchResults uses SQL query rather than GetMarcFromKohaField

Simple change.
Does not break anything.
Save 1 query to database because result of GetMarcFromKohaField is cached.
Signed off.
Comment 3 Jonathan Druart 2012-08-16 12:24:12 UTC
QA Comment:

use the routine GetMarcFromKohaField instead of execute an sql query.

Marked as Passed QA
Comment 4 Chris Cormack 2012-08-29 21:48:45 UTC
Pushed to 3.8.x, will be in 3.8.5