Summary: | Koha::Calendar not loading both sets of special dates | ||
---|---|---|---|
Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
Component: | Circulation | Assignee: | Colin Campbell <colin.campbell> |
Status: | CLOSED FIXED | QA Contact: | Mason James <mtj> |
Severity: | major | ||
Priority: | P1 - high | CC: | chris, gmcharlt, kyle.m.hall, mtj, paul.poulain |
Version: | 3.8 | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed Patch
Bug 8656 Calendar needs to load both exception and nonexception dates |
Description
Colin Campbell
2012-08-20 14:19:46 UTC
Created attachment 11703 [details] [review] Proposed Patch Created attachment 11734 [details] [review] Bug 8656 Calendar needs to load both exception and nonexception dates single_holidays and exception_holidays were both being selected with the same parameter with the result that single holidays were not being loaded. Have removed the retrieval of the unused parameters title and description. In effect the distinction is not meaningful for these routines and the two structures could become one. This patch just fixes the current bug Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Colin, i upgraded the priority patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * d40a73c Bug 8656 Calendar needs to load both exception and nonexception d Koha/Calendar.pm * Koha/Calendar.pm OK Patch pushed to master Pushed to 3.8.x, will be 3.8.5 |