Summary: | Remove unused famfamfam icons | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jonathan.druart, kyle, magnus |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 8624, 8793 | ||
Bug Blocks: | |||
Attachments: |
Bug 8662 - Remove unused famfamfam icons
Bug 8662 - Remove unused famfamfam icons [SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons [SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons Bug 8662 - Remove unused famfamfam icons |
Description
Owen Leonard
2012-08-21 19:29:32 UTC
NORMARC XSLT has been using some famfamfam icons from the big collection, but if the patch on bug 8793 gets pushed it will only use icons from koha-tmpl/opac-tmpl/lib/famfamfam/ and koha-tmpl/intranet-tmpl/prog/img/famfamfam/ (not from the silk/ dirs below these dirs). So no objections from the Norwegian jury! ;-) Created attachment 13036 [details] [review] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Created attachment 13940 [details] [review] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> I'm seeing no ill effects from the patch. I'm one of those people who'd rather keep all the images around just in case, but I do realize that we will never use 90% of these. How to be sure that nobody use these files for a specific theme (for example)? Perhaps asking through a topic on koha and koha-devel would be good idea don't you think? Can we get one or two more opinions on this one? Not many opinions were forthcoming: http://lists.katipo.co.nz/public/koha/2013-April/035944.html I think we should move this forward as there was no negative response to the idea. Owen, could you resubmit a rebased patch please? Applying: Bug 8662 - Remove unused famfamfam icons Using index info to reconstruct a base tree... error: patch failed: koha-tmpl/opac-tmpl/lib/famfamfam/mini/readme.txt:1 error: koha-tmpl/opac-tmpl/lib/famfamfam/mini/readme.txt: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. Created attachment 18530 [details] [review] [SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Owen, I'm still getting the same error applying the last patch :-/ I got another error using --ignore-whitespace: # git am -3 --ignore-whitespace /tmp/BZ8662.patch Applying: Bug 8662 - Remove unused famfamfam icons error: corrupt binary patch at line 7593: z^9B<YSk|5uEYsxu!9bPB+;6=<UKb0;G`E{jgY|m- Using index info to reconstruct a base tree... error: corrupt binary patch at line 7593: z^9B<YSk|5uEYsxu!9bPB+;6=<UKb0;G`E{jgY|m- error: removal patch leaves file contents error: koha-tmpl/opac-tmpl/lib/famfamfam/silk/calculator.png: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Created attachment 18548 [details] [review] [SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Sorry Owen but I always get the same error, tested on several instance :-/ Could someone else try to apply it? Created attachment 18917 [details] [review] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Pushed to master. Thanks, Owen! |