Summary: | Add floating toolbar with save button to system preferences editor | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | System Administration | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | chris, gmcharlt, jcamins, jonathan.druart, martin.renvoize, mirko, nengard |
Version: | 3.12 | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3988 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Bug 8664 - Add floating toolbar with save button to system preferences editor
Bug 8664 - Add floating toolbar with save button to system preferences editor |
Description
Owen Leonard
2012-08-21 20:29:21 UTC
Created attachment 13059 [details] [review] Bug 8664 - Add floating toolbar with save button to system preferences editor This patch adds a copy of the "save" button in a toolbar at the top of the system preferences editor. The toolbar becomes fixed at the top of the page when you scroll down, exactly like the toolbar on addbiblio.pl. Because multiple save buttons might appear when the system prefs page displays search results, the toolbar does not appear in this case. To test, open the system preferences editor and change a setting. Try saving both with the button in the toolbar and the button at the top of the page. Test scrolling to confirm that the toolbar "sticks" to the top of the page when you scroll down. Created attachment 13060 [details] [review] Bug 8664 - Add floating toolbar with save button to system preferences editor This patch adds a copy of the "save" button in a toolbar at the top of the system preferences editor. The toolbar becomes fixed at the top of the page when you scroll down, exactly like the toolbar on addbiblio.pl. Because multiple save buttons might appear when the system prefs page displays search results, the toolbar does not appear in this case. To test, open the system preferences editor and change a setting. Try saving both with the button in the toolbar and the button at the top of the page. Test scrolling to confirm that the toolbar "sticks" to the top of the page when you scroll down. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> *** Bug 3988 has been marked as a duplicate of this bug. *** QA Comments: Works as expected. Just one remark about indentation, I am not a big fan of this kind of indendation: + [% UNLESS ( searchfield ) %]$(document).ready(function(){ + $('#toolbar').fixFloat(); + });[% END %] It is not blocker and we don't have enough guidelines on the template files structure. So marked as Passed QA. This patch has been pushed to master. |