Summary: | Remove usage of Amazon API | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Architecture, internals, and plumbing | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | jonathan.druart, nengard, paul.poulain |
Version: | 3.10 | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
Bug 8679 - Remove usage of Amazon API
[SIGNED-OFF] Bug 8679 - Remove usage of Amazon API Bug 8679 [REVISED] Remove usage of Amazon API [SIGNED-OFF] Bug 8679 [REVISED] Remove usage of Amazon API |
Description
Owen Leonard
2012-08-23 17:21:14 UTC
+1 Created attachment 11807 [details] [review] Bug 8679 - Remove usage of Amazon API This patch removes the AmazonReviews and AmazonSimilarItems features from the OPAC and staff client. With on Amazon feature remaining, cover images, the *AmazonEnabled preference is also removed in favor of checking the *AmazonCoverImages preference. The Amazon module is removed. Two other system preferences, AWSAccessKeyID and AWSPrivateKey are removed as they were required only by Amazon.pm. Handling of book cover images from Amazon is unchanged. Created attachment 11808 [details] [review] [SIGNED-OFF] Bug 8679 - Remove usage of Amazon API This patch removes the AmazonReviews and AmazonSimilarItems features from the OPAC and staff client. With on Amazon feature remaining, cover images, the *AmazonEnabled preference is also removed in favor of checking the *AmazonCoverImages preference. The Amazon module is removed. Two other system preferences, AWSAccessKeyID and AWSPrivateKey are removed as they were required only by Amazon.pm. Handling of book cover images from Amazon is unchanged. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Turned on amazon covers in opac and staff client and all worked as expected. Then tested to make sure other cover image services still worked and they do. Signing off. QA Comments: All seems good. But there is 1 occurrence left of C4::External::Amazon in the unit test : t/db_dependent/Amazon.t Marked as Failed QA Created attachment 11863 [details] [review] Bug 8679 [REVISED] Remove usage of Amazon API This patch removes the AmazonReviews and AmazonSimilarItems features from the OPAC and staff client. With on Amazon feature remaining, cover images, the *AmazonEnabled preference is also removed in favor of checking the *AmazonCoverImages preference. Two other system preferences, AWSAccessKeyID and AWSPrivateKey are removed as they were required only by the removed features. Handling of book cover images from Amazon is unchanged. Created attachment 11864 [details] [review] [SIGNED-OFF] Bug 8679 [REVISED] Remove usage of Amazon API This patch removes the AmazonReviews and AmazonSimilarItems features from the OPAC and staff client. With on Amazon feature remaining, cover images, the *AmazonEnabled preference is also removed in favor of checking the *AmazonCoverImages preference. Two other system preferences, AWSAccessKeyID and AWSPrivateKey are removed as they were required only by the removed features. Handling of book cover images from Amazon is unchanged. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Turned on amazon covers in opac and staff client and all worked as expected. Then tested to make sure other cover image services still worked and they do. Signing off. Marked as Passed QA Patch pushed. I suggest that it's not backported to 3.8 even it's it's a bugfix, because some hidden problem could be hard to detect. I checked that there is no more occurrences of the removed sysprefs or subs, could not find any problem |