Summary: | Raise required version of URI::Escape to 3.31 | ||
---|---|---|---|
Product: | Koha | Reporter: | Nicole C. Engard <nengard> |
Component: | Architecture, internals, and plumbing | Assignee: | Katrin Fischer <katrin.fischer> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | major | ||
Priority: | P5 - low | CC: | chris, jonathan.druart, liz, mtj, robin, tomascohen |
Version: | Main | Keywords: | dependency |
Hardware: | All | ||
OS: | All | ||
URL: | cgi-bin/koha/catalogue/search.pl?q=au:%22Engard,%20Nicole%20C.,%22 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: |
author search
no check boxes search settings Bug 8686: Raise required version of URI::Escape to 3.31 Bug 8686: Raise required version of URI::Escape to 3.31 Bug 8686: Raise required version of URI::Escape to 3.31 |
I cannot reproduce this bug. I'm wondering if there are some system preferences in play here. I see your screenshot has no cover images, so I turned those off. Is that correct? XSLT display? Custom javascript in use? It's not happening anymore .. not sure what it was, but it wasn't custom xslt cause I don't have that :) Okay it's happening again. cgi-bin/koha/catalogue/search.pl?q=au:"Tepper, Sheri S." Created attachment 12564 [details]
no check boxes
That link by the way came from me clicking an author name on a bib record - not by searching for an author via the search screen. If I search from the search box it shows the checkboxes. But the URL is different. cgi-bin/koha/catalogue/search.pl?idx=au%2Cphr&q=tepper%2C+sheri+s.&op=and&idx=kw&op=and&idx=kw&sort_by=relevance So the problem is with the author link on bib records in the staff client. Nicole Also if you click the author name on a bib record on the search results you get the same result. (In reply to comment #3) > cgi-bin/koha/catalogue/search.pl?q=au:"Tepper, Sheri S." I still can't reproduce this on my system. I can on ByWater's demo, and I notice that removing the quotes from that URL fixes the problem. Now I'm guessing I can't reproduce the error because I have a different search configuration? Created attachment 12596 [details]
search settings
I am doing this on my own install, so here are my settings for searching
It looks to me like this is a JavaScript problem because a variable being passed to JavaScript isn't properly escaped (hence the difference bewteen <"Tepper, Sheri S."> and <Tepper, Sheri S.>. Tracing the variable back leads me to Search.pm, line 2770: for my $field (qw/ lccn isbn issn title author dewey subject /) { my $encvalue = URI::Escape::uri_escape_utf8($bibrec->{$field}); push @$array, { name=>$field, value=>$bibrec->{$field}, encvalue=>$encvalue } if defined $bibrec->{$field}; } I think $encvalue is different on systems which show the error. My copy of URI::Escape is version 3.31, but ByWater's demo reports 3.30. Could that version difference be the source of the different outcomes? Owen, I'm not using ByWater's demo ... I'm using my own local install of Master ... so I don't know what's up with the demo site (it's not on the most recent version of master) Nicole's comment from Bug 9990: "This stops happening if you upgrade URI::Escape to 3.31. We should make it clear in the Perl Modules page that an upgrade is needed." *** Bug 9990 has been marked as a duplicate of this bug. *** See this video: http://www.screencast.com/t/tETuccHQ still an issue in 3.14.x The mininum required version of URI::Escape is listed as 'min_ver' => '1.36' Robin, is raising the version here a problem for packages? (In reply to Katrin Fischer from comment #14) > The mininum required version of URI::Escape is listed as > 'min_ver' => '1.36' > > Robin, is raising the version here a problem for packages? Nope, URI::Escape 3.31 is contained in URI 1.60, which is in Wheezy. http://search.cpan.org/~gaas/URI-1.60/ https://packages.debian.org/search?keywords=liburi-perl&searchon=names&suite=all§ion=all So everything should be fine ☺ wow. quick reply :) Thx! Created attachment 39961 [details] [review] Bug 8686: Raise required version of URI::Escape to 3.31 Raises the minimum required version of URI::Escape from 1.36 to 3.31. Created attachment 40113 [details] [review] Bug 8686: Raise required version of URI::Escape to 3.31 Raises the minimum required version of URI::Escape from 1.36 to 3.31. TEST PLAN --------- 1) git branch -b bug_8686 origin/master 2) ./koha_perl_deps.pl -a | grep URI -- it will list 1.36 required 3) git bz apply 8686 4) ./koha_perl_deps.pl -a | grep URI -- it will list 3.31 required 5) koha qa test tools NOTE: Also default in Ubuntu 14.04 LTS, not just Wheezy as noted in comment #15. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 40270 [details] [review] Bug 8686: Raise required version of URI::Escape to 3.31 Raises the minimum required version of URI::Escape from 1.36 to 3.31. TEST PLAN --------- 1) git branch -b bug_8686 origin/master 2) ./koha_perl_deps.pl -a | grep URI -- it will list 1.36 required 3) git bz apply 8686 4) ./koha_perl_deps.pl -a | grep URI -- it will list 3.31 required 5) koha qa test tools NOTE: Also default in Ubuntu 14.04 LTS, not just Wheezy as noted in comment #15. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signoff based on Nicole's comment (bug 9990 comment 6): "This stops happening if you upgrade URI::Escape to 3.31. We should make it clear in the Perl Modules page that an upgrade is needed." Patch pushed to master. Thanks Katrin! Pushed to 3.20.x will be in 3.20.2 Pushed to 3.18.x, will be in 3.18.09 Pushed to 3.16.x, will be in 3.16.13 |
Created attachment 11825 [details] author search The menu bar that lets you put things in lists and such at the top of the results in the staff client goes away - along with the check boxes when you do an author search. See attached.